E2E: QA updated current accceptance test project README to match current project #21063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
Updated the README documentation for the Umbraco Acceptance Test project to provide comprehensive guidance on test execution, writing patterns, and available tooling.
Key Changes:
- Expanded test execution documentation with detailed NPM script descriptions and examples
- Added comprehensive test helper documentation (
umbracoUi,umbracoApi, fixtures) - Introduced test writing conventions following the AAA (Arrange-Act-Assert) pattern with code examples
nhudinh0309
approved these changes
Dec 5, 2025
Contributor
nhudinh0309
left a comment
nhudinh0309
left a comment
There was a problem hiding this comment.
Looks good to me.
Just had a small comment. You can merge after fixing.
Co-authored-by: Nhu Dinh <[email protected]>
Co-authored-by: Nhu Dinh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated read me with help from Claude 🙏