Webhooks: Added 'mandatory' tag as a visual indicator for at lease one webhook event being required #21075
+9
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a visual mandatory indicator (asterisk) to the webhook events field in the webhook details workspace view to improve user experience by clearly indicating that the field is required. The change addresses issue #21025 by making it consistent with the existing URL field which already has a mandatory indicator.
Key Changes:
- Added
mandatoryattribute to the webhook events<umb-property-layout>component - Reformatted the URL field's
<uui-input>for better code readability (no functional change)
…response problem details message.
AndyButland
approved these changes
Dec 5, 2025
Contributor
AndyButland
left a comment
AndyButland
left a comment
There was a problem hiding this comment.
Thanks @Frost117 - visual update looks good, but I just thought we could improve the messaging from the API given we have this case of "no events specified" defined as an operation status. So I pushed an update to do that.
AndyButland
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
This pr adds asterisk for the web event modal to indicate it being mandatory, for this issue:
#21025
Description
It is only a visual indicator as the src/Umbraco.Web.UI.Client/src/packages/webhook/webhook-event/input-webhook-events.element.ts does not have any input to bobble up, like we have with the uui-input field. Meaning using the required=true attribute isn't available on the umb-input-webhook-events.
There is validation event from the backend that it doesn't know what operation it is when the field is left empty.
Changes
From:
To this:
Current validation when events is left blank and you save:
