Skip to content

Commit 39b2cb1

Browse files
authored
Fix/hfc retrain with tfm and ocs (#2869)
* update ocs * try fixing ocs retrain start issue * add ocs test for torch models * update tests
1 parent cbf1c1a commit 39b2cb1

File tree

4 files changed

+98
-75
lines changed

4 files changed

+98
-75
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ but cannot always guarantee backwards compatibility. Changes that may **break co
2424
- Fixed a bug in `darts.utils.timeseries_generation.sine_timeseries()`, where the returned series ignored the specified `dtype`. [#2856](https://github.com/unit8co/darts/pull/2856) by [Dennis Bader](https://github.com/dennisbader).
2525
- Fixed a bug in `TimeSeries.__getitem__()`, where indexing with a list of integers of `length <= 2` resulted in an error. [#2857](https://github.com/unit8co/darts/pull/2857) by [Dennis Bader](https://github.com/dennisbader).
2626
- Fixed a bug in `TorchForecastingModel` which raised an error when calling any predict method after training the model with `fit_from_dataset()` on a dataset that uses static covariates. [#2860](https://github.com/unit8co/darts/pull/2860) by [Dennis Bader](https://github.com/dennisbader).
27+
- Fixed a bug in `ForecastingModel.historical_forecasts`, where calling the method with `retrain=True`, `start=None`, and a model that uses `output_chunk_shift > 0` raised an error due to the start point not being properly inferred. [#2869](https://github.com/unit8co/darts/pull/2869) by [Dennis Bader](https://github.com/dennisbader).
2728
- Removed `darts/tests` and `examples` from the Darts package distribution. These are only required for internal testing. [#2854](https://github.com/unit8co/darts/pull/2854) by [Dennis Bader](https://github.com/dennisbader).
2829

2930
**Dependencies**

darts/models/forecasting/forecasting_model.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1111,7 +1111,7 @@ def retrain_func(
11111111
)
11121112

11131113
# adjust the start of the series depending on whether we train (at some point), or predict only
1114-
# must be performed after the operation on historical_foreacsts_time_index
1114+
# must be performed after the operation on historical_forecasts_time_index
11151115
if min_timestamp_series > series_.time_index[0]:
11161116
series_ = series_.drop_before(min_timestamp_series - 1 * series_.freq)
11171117

0 commit comments

Comments
 (0)