Fix CI regression test for contract sizes (#2444)

* Remove `todo`

* Upload artifact with `name`

Author: cmichi

.github/workflows/ci.yml

@@ -767,7 +767,6 @@ jobs:
   examples-contract-build-riscv:
     runs-on: ubuntu-latest
     needs: [set-image]
-    # todo
     # needs: [set-image, build-std, build-riscv]
     defaults:
       run:
@@ -848,6 +847,7 @@ jobs:
 
       - uses: actions/upload-artifact@v4
         with:
+            name: measurements-${{ steps.extract_branch.outputs.branch }}
             path: ./measurements-${{ steps.extract_branch.outputs.branch }}
             retention-days: 31
 

crates/primitives/src/types.rs

@@ -422,8 +422,6 @@ pub trait Environment: Clone {
 
     /// TODO comment
     type EventRecord: 'static + scale::Codec;
-
-    // type AddressMapper: 'static + AddressMapper<Self>;
 }
 
 /// Placeholder for chains that have no defined chain extension.
@@ -435,8 +433,6 @@ pub enum NoChainExtension {}
 #[cfg_attr(feature = "std", derive(TypeInfo))]
 pub enum DefaultEnvironment {}
 
-//use sp_core::crypto::AccountId32;
-//use sp_runtime::AccountId32;
 impl Environment for DefaultEnvironment {
     const MAX_EVENT_TOPICS: usize = 4;
 

integration-tests/public/upgradeable-contracts/delegator/lib.rs

@@ -25,6 +25,7 @@ pub mod delegator {
     pub struct Delegator {
         addresses: Mapping<H160, i32, ManualKey<0x23>>,
         counter: i32,
+        // TODO check if we even need to save the `H256` hash in here.
         delegate_to: Lazy<(H256, H160)>,
     }