-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
fix: make thumbnail generation for images in S3 configurable #5185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
FloDwld
wants to merge
12
commits into
usememos:main
Choose a base branch
from
FloDwld:fix/configurable-s3-thumbnails
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+138
−30
Open
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
cb84b7b
Introduce setting to disable thumbnail loading and generation when im…
FloDwld 2d4acb9
Fix prettier errors
FloDwld 067f678
Move settings whether to generate thumbnails for S3 images to storage…
FloDwld 08eecd5
Reduce diff to main branch
FloDwld db23ee5
Move language key to storage related section
FloDwld 2a2b164
Pass workspace settings as paramter to convertAttachmentFromStore
FloDwld 1aa30ec
Rebase with main and regenerate protobuf
FloDwld aae0e56
Rename variable use_thumbnails_for_s3_images to enable_s3_image_thumb…
FloDwld 2ed02b2
Make GetWorkspaceSetting return non-sensitive values to low-privilege…
FloDwld 9666fb1
Make frontend use value stored in storageSettings to decide whether t…
FloDwld 55025e1
Remove previous variable from attachment API message
FloDwld db412ae
Minimize differences in openapi.yaml
FloDwld File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.