Adding TTY helper for unix to be able to create tests for stty and more (#9348)

* Adding TTY helper for unix to be able to create tests for stty and more

* removing missing flag on github actions and spellcheck ignore

Author: ChrisDryden

tests/by-util/test_stty.rs

@@ -2,41 +2,52 @@
 //
 // For the full copyright and license information, please view the LICENSE
 // file that was distributed with this source code.
-// spell-checker:ignore parenb parmrk ixany iuclc onlcr ofdel icanon noflsh econl igpar ispeed ospeed
+// spell-checker:ignore parenb parmrk ixany iuclc onlcr icanon noflsh econl igpar ispeed ospeed
 
 use uutests::new_ucmd;
+use uutests::util::pty_path;
 
 #[test]
 fn test_invalid_arg() {
     new_ucmd!().arg("--definitely-invalid").fails_with_code(1);
 }
 
 #[test]
-#[ignore = "Fails because cargo test does not run in a tty"]
-fn runs() {
-    new_ucmd!().succeeds();
+#[cfg(unix)]
+fn test_basic() {
+    let (path, _controller, _replica) = pty_path();
+    new_ucmd!()
+        .args(&["--file", &path])
+        .succeeds()
+        .stdout_contains("speed");
 }
 
 #[test]
-#[ignore = "Fails because cargo test does not run in a tty"]
-fn print_all() {
-    let res = new_ucmd!().args(&["--all"]).succeeds();
-
-    // Random selection of flags to check for
-    for flag in [
-        "parenb", "parmrk", "ixany", "onlcr", "ofdel", "icanon", "noflsh",
-    ] {
-        res.stdout_contains(flag);
+#[cfg(unix)]
+fn test_all_flag() {
+    let (path, _controller, _replica) = pty_path();
+    let result = new_ucmd!().args(&["--all", "--file", &path]).succeeds();
+
+    for flag in ["parenb", "parmrk", "ixany", "onlcr", "icanon", "noflsh"] {
+        result.stdout_contains(flag);
     }
 }
 
 #[test]
-#[ignore = "Fails because cargo test does not run in a tty"]
-fn sane_settings() {
-    new_ucmd!().args(&["intr", "^A"]).succeeds();
-    new_ucmd!().succeeds().stdout_contains("intr = ^A");
+#[cfg(unix)]
+fn test_sane() {
+    let (path, _controller, _replica) = pty_path();
+
+    new_ucmd!()
+        .args(&["--file", &path, "intr", "^A"])
+        .succeeds();
+    new_ucmd!()
+        .args(&["--file", &path])
+        .succeeds()
+        .stdout_contains("intr = ^A");
+    new_ucmd!().args(&["--file", &path, "sane"]).succeeds();
     new_ucmd!()
-        .args(&["sane"])
+        .args(&["--file", &path])
         .succeeds()
         .stdout_str_check(|s| !s.contains("intr = ^A"));
 }

tests/uutests/src/lib/util.rs

@@ -4,6 +4,7 @@
 // file that was distributed with this source code.
 //spell-checker: ignore (linux) rlimit prlimit coreutil ggroups uchild uncaptured scmd SHLVL canonicalized openpty
 //spell-checker: ignore (linux) winsize xpixel ypixel setrlimit FSIZE SIGBUS SIGSEGV sigbus tmpfs mksocket
+//spell-checker: ignore (ToDO) ttyname
 
 #![allow(dead_code)]
 #![allow(
@@ -2886,6 +2887,24 @@ pub fn whoami() -> String {
         })
 }
 
+/// Create a PTY (pseudo-terminal) for testing utilities that require a TTY.
+///
+/// Returns a tuple of (path, controller_fd, replica_fd) where:
+/// - path: The filesystem path to the PTY replica device
+/// - controller_fd: The controller file descriptor
+/// - replica_fd: The replica file descriptor
+#[cfg(unix)]
+pub fn pty_path() -> (String, OwnedFd, OwnedFd) {
+    use nix::pty::openpty;
+    use nix::unistd::ttyname;
+    let pty = openpty(None, None).expect("Failed to create PTY");
+    let path = ttyname(&pty.slave)
+        .expect("Failed to get PTY path")
+        .to_string_lossy()
+        .to_string();
+    (path, pty.master, pty.slave)
+}
+
 /// Add prefix 'g' for `util_name` if not on linux
 #[cfg(unix)]
 pub fn host_name_for(util_name: &str) -> Cow<'_, str> {