stty: columns env support and integration testing #9490
+185
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do the same as GNU stty when it has to prints the parameter, doing proper text wrapping
ChrisDryden
force-pushed
the
columns_env_support
branch
2 times, most recently
from
3e6051f to
96937d3
Compare
CodSpeed Performance ReportMerging #9490 will not alter performanceComparing Summary
Footnotes
|
|
GNU testsuite comparison: |
ChrisDryden
force-pushed
the
columns_env_support
branch
2 times, most recently
from
53628a6 to
bf1f813
Compare
|
GNU testsuite comparison: |
ChrisDryden
force-pushed
the
columns_env_support
branch
from
bf1f813 to
0ed9bf5
Compare
ChrisDryden
force-pushed
the
columns_env_support
branch
from
0ed9bf5 to
c3e31fd
Compare
|
GNU testsuite comparison: |
Contributor
Author
|
Am so glad that we now have the integ tests running on the CI for this binary, it spotted a bunch of stuff. |
|
GNU testsuite comparison: |
sylvestre
reviewed
Nov 26, 2025
Contributor
Author
|
Moved the libc to a helper function with comments and added some comments to the main wrapped printer class |
Contributor
Author
|
The only errors are coming from this PR: #9471 |
This was referenced Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes the commit from @3v1n0 to split it from the rest of his PR to add the feature of reading from the COLUMNS variable to determine how long the lines are in the output. This is because the changes in that PR related to the flags are separate and it might be a while until some upstream changes related to that change are merged.
I added tests that cover that when printing, ideally once we expect the output of the --all command to be matching we should be able to add GNU matching testing to the COLUMNS tests. These integ tests match how the GNU integ tests validate that this env variable is working properly
#9432 this is the PR where the COLUMNS support is added from
When reviewing this, an important thing to note is that the COLUMNS environment variable is only used when piping output.