tar/asm: don't add a padding entry if it has no bytes

vbatts · vbatts · commit b6372414e507 · 2023-07-21T09:02:43.000-04:00
Fixes #65 if the read bytes is 0, then don't even create the entry for that padding. This sounds like the solution for the issue opened, but I haven't found a reproducer for this issue yet. :-\ Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
diff --git a/tar/asm/disassemble.go b/tar/asm/disassemble.go
@@ -135,6 +135,9 @@ func NewInputTarStream(r io.Reader, p storage.Packer, fp storage.FilePutter) (io
 				}
 				isEOF = true
 			}
+			if n == 0 {
+				break
+			}
 			_, err = p.AddEntry(storage.Entry{
 				Type:    storage.SegmentType,
 				Payload: paddingChunk[:n],

Original file line number	Diff line number	Diff line change
`@@ -135,6 +135,9 @@ func NewInputTarStream(r io.Reader, p storage.Packer, fp storage.FilePutter) (io`
`135`	`135`	`}`
`136`	`136`	`isEOF = true`
`137`	`137`	`}`
	`138`	`+ if n == 0 {`
	`139`	`+ break`
	`140`	`+ }`
`138`	`141`	`_, err = p.AddEntry(storage.Entry{`
`139`	`142`	`Type: storage.SegmentType,`
`140`	`143`	`Payload: paddingChunk[:n],`