golangci-lint: add perfsprint linter and auto-fixes (#18830)

Signed-off-by: Tim Vaillancourt <[email protected]>

Author: timvaillancourt

.golangci.yml

@@ -9,6 +9,7 @@ linters:
     - errcheck
     - govet
     - ineffassign
+    - perfsprint
     - staticcheck
   settings:
     depguard:

go/cache/theine/list_test.go

@@ -18,7 +18,6 @@ limitations under the License.
 package theine
 
 import (
-	"fmt"
 	"strconv"
 	"testing"
 
@@ -45,7 +44,7 @@ func TestList(t *testing.T) {
 
 	for i := range 5 {
 		entry := l.PopTail()
-		require.Equal(t, StringKey(fmt.Sprintf("%d", i+1)), entry.key)
+		require.Equal(t, StringKey(strconv.Itoa(i+1)), entry.key)
 	}
 	entry := l.PopTail()
 	require.Nil(t, entry)

go/cache/theine/tlfu_test.go

@@ -19,6 +19,7 @@ package theine
 
 import (
 	"fmt"
+	"strconv"
 	"strings"
 	"testing"
 
@@ -34,7 +35,7 @@ func TestTlfu(t *testing.T) {
 
 	var entries []*Entry[StringKey, string]
 	for i := range 200 {
-		e := NewEntry(StringKey(fmt.Sprintf("%d", i)), "", 1)
+		e := NewEntry(StringKey(strconv.Itoa(i)), "", 1)
 		evicted := tlfu.Set(e)
 		entries = append(entries, e)
 		require.Nil(t, evicted)
@@ -52,7 +53,7 @@ func TestTlfu(t *testing.T) {
 	require.Equal(t, 1, tlfu.slru.protected.len)
 
 	for i := 200; i < 1000; i++ {
-		e := NewEntry(StringKey(fmt.Sprintf("%d", i)), "", 1)
+		e := NewEntry(StringKey(strconv.Itoa(i)), "", 1)
 		entries = append(entries, e)
 		evicted := tlfu.Set(e)
 		require.Nil(t, evicted)

go/cmd/mysqlctl/command/root.go

@@ -17,7 +17,7 @@ limitations under the License.
 package command
 
 import (
-	"fmt"
+	"errors"
 
 	"github.com/spf13/cobra"
 
@@ -49,7 +49,7 @@ var (
 			}
 
 			if vtcmd.IsRunningAsRoot() {
-				return fmt.Errorf("mysqlctl cannot be run as root. Please run as a different user")
+				return errors.New("mysqlctl cannot be run as root. Please run as a different user")
 			}
 
 			return nil

go/cmd/vtbackup/cli/vtbackup.go

@@ -380,7 +380,7 @@ func takeBackup(ctx, backgroundCtx context.Context, topoServer *topo.Server, bac
 	}
 	dbName := initDbNameOverride
 	if dbName == "" {
-		dbName = fmt.Sprintf("vt_%s", initKeyspace)
+		dbName = "vt_" + initKeyspace
 	}
 
 	backupParams := mysqlctl.BackupParams{
@@ -467,7 +467,7 @@ func takeBackup(ctx, backgroundCtx context.Context, topoServer *topo.Server, bac
 	case mysqlctl.ErrNoBackup:
 		// There is no backup found, but we may be taking the initial backup of a shard
 		if !allowFirstBackup {
-			return fmt.Errorf("no backup found; not starting up empty since --initial_backup flag was not enabled")
+			return errors.New("no backup found; not starting up empty since --initial_backup flag was not enabled")
 		}
 		restorePos = replication.Position{}
 	default:
@@ -854,14 +854,14 @@ func shouldBackup(ctx context.Context, topoServer *topo.Server, backupStorage ba
 
 	// We need at least one backup so we can restore first, unless the user explicitly says we don't
 	if len(backups) == 0 && !allowFirstBackup {
-		return false, fmt.Errorf("no existing backups to restore from; backup is not possible since --initial_backup flag was not enabled")
+		return false, errors.New("no existing backups to restore from; backup is not possible since --initial_backup flag was not enabled")
 	}
 	if lastBackup == nil {
 		if allowFirstBackup {
 			// There's no complete backup, but we were told to take one from scratch anyway.
 			return true, nil
 		}
-		return false, fmt.Errorf("no complete backups to restore from; backup is not possible since --initial_backup flag was not enabled")
+		return false, errors.New("no complete backups to restore from; backup is not possible since --initial_backup flag was not enabled")
 	}
 
 	// Has it been long enough since the last complete backup to need a new one?

go/cmd/vtctldclient/cli/tablets.go

@@ -17,6 +17,7 @@ limitations under the License.
 package cli
 
 import (
+	"errors"
 	"fmt"
 	"strings"
 
@@ -45,7 +46,7 @@ func TabletAliasesFromPosArgs(args []string) ([]*topodatapb.TabletAlias, error)
 // converts them to a map of tablet tags.
 func TabletTagsFromPosArgs(args []string) (map[string]string, error) {
 	if len(args) == 0 {
-		return nil, fmt.Errorf("no tablet tags specified")
+		return nil, errors.New("no tablet tags specified")
 	}
 
 	tags := make(map[string]string, len(args))

go/cmd/vtctldclient/command/backups.go

@@ -17,6 +17,7 @@ limitations under the License.
 package command
 
 import (
+	"errors"
 	"fmt"
 	"io"
 	"strings"
@@ -243,7 +244,7 @@ func commandRestoreFromBackup(cmd *cobra.Command, args []string) error {
 	}
 
 	if restoreFromBackupOptions.RestoreToPos != "" && restoreFromBackupOptions.RestoreToTimestamp != "" {
-		return fmt.Errorf("--restore-to-pos and --restore-to-timestamp are mutually exclusive")
+		return errors.New("--restore-to-pos and --restore-to-timestamp are mutually exclusive")
 	}
 
 	var restoreToTimestamp time.Time

go/cmd/vtctldclient/command/root_test.go

@@ -18,7 +18,6 @@ package command_test
 
 import (
 	"context"
-	"fmt"
 	"os"
 	"testing"
 	"time"
@@ -85,7 +84,7 @@ func TestRootWithInternalVtctld(t *testing.T) {
 	}{
 		{
 			command:   "AddCellInfo",
-			args:      []string{"--root", fmt.Sprintf("/vitess/%s", cell), "--server-address", "", cell},
+			args:      []string{"--root", "/vitess/" + cell, "--server-address", "", cell},
 			expectErr: "node already exists", // Cell already exists
 		},
 		{

go/cmd/vtctldclient/command/throttler.go

@@ -17,6 +17,7 @@ limitations under the License.
 package command
 
 import (
+	"errors"
 	"fmt"
 	"time"
 
@@ -75,10 +76,10 @@ var (
 
 func validateUpdateThrottlerConfig(cmd *cobra.Command, args []string) error {
 	if updateThrottlerConfigOptions.MetricName != "" && !cmd.Flags().Changed("threshold") {
-		return fmt.Errorf("--metric-name flag requires --threshold flag. Set threshold to 0 to disable the metric threshold configuration")
+		return errors.New("--metric-name flag requires --threshold flag. Set threshold to 0 to disable the metric threshold configuration")
 	}
 	if cmd.Flags().Changed("app-name") && updateThrottlerConfigOptions.AppName == "" {
-		return fmt.Errorf("--app-name must not be empty")
+		return errors.New("--app-name must not be empty")
 	}
 
 	return nil

go/cmd/vtctldclient/command/vreplication/common/cancel.go

@@ -17,6 +17,7 @@ limitations under the License.
 package common
 
 import (
+	"errors"
 	"fmt"
 	"sort"
 
@@ -70,7 +71,7 @@ func commandCancel(cmd *cobra.Command, args []string) error {
 	resp, err := GetClient().WorkflowDelete(GetCommandCtx(), req)
 	if err != nil {
 		if grpcerr, ok := status.FromError(err); ok && (grpcerr.Code() == codes.DeadlineExceeded) {
-			return fmt.Errorf("Cancel action timed out. Please try again and the work will pick back up where it left off. Note that you can control the timeout using the --action_timeout flag and the delete batch size with --delete-batch-size.")
+			return errors.New("Cancel action timed out. Please try again and the work will pick back up where it left off. Note that you can control the timeout using the --action_timeout flag and the delete batch size with --delete-batch-size.")
 		}
 		return err
 	}