Skip to content

Commit d0592e2

Browse files
fix ut test
Signed-off-by: hfadzxy <[email protected]>
1 parent 54d0895 commit d0592e2

File tree

4 files changed

+3
-9
lines changed

4 files changed

+3
-9
lines changed

.github/workflows/vllm_ascend_test.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,10 +70,10 @@ jobs:
7070
- 'tests/ut/**'
7171
7272
ut:
73-
needs: [lint, changes]
73+
# needs: [lint, changes]
7474
name: unit test
7575
# only trigger unit test after lint passed and the change is e2e and ut related.
76-
if: ${{ needs.lint.result == 'success' && (needs.changes.outputs.e2e_tracker == 'true' || needs.changes.outputs.ut_tracker == 'true') }}
76+
# if: ${{ needs.lint.result == 'success' && (needs.changes.outputs.e2e_tracker == 'true' || needs.changes.outputs.ut_tracker == 'true') }}
7777
runs-on: ubuntu-latest
7878
container:
7979
# fixme: vllm-ascend install failed with 8.3.rc1 on github action

.github/workflows/vllm_ascend_test_report.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ on:
2828
- 'main'
2929
- '*-dev'
3030
paths:
31-
- '.github/workflows/vllm_ascend_test_report.yaml'
31+
# - '.github/workflows/vllm_ascend_test_report.yaml'
3232
- 'tests/e2e/models/test_lm_eval_correctness.py'
3333
workflow_dispatch:
3434
inputs:

tests/ut/torchair/test_torchair_worker.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,6 @@ def test_init_device(self, mock_platform, mock_init_dist_env):
5757
worker.model_config = MagicMock()
5858
worker.model_config.seed = 42
5959
worker.vllm_config = MagicMock()
60-
worker.parallel_config = MagicMock()
61-
worker.parallel_config.local_world_size = 1
6260

6361
result = worker._init_device()
6462

@@ -91,8 +89,6 @@ def test_init_device_torchair_worker(self, mock_platform,
9189
worker.model_config = MagicMock()
9290
worker.model_config.seed = 42
9391
worker.vllm_config = MagicMock()
94-
worker.parallel_config = MagicMock()
95-
worker.parallel_config.local_world_size = 1
9692

9793
result = worker._init_device()
9894

tests/ut/worker/test_worker_v1.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -327,8 +327,6 @@ def test_init_device(self, mock_platform, mock_init_dist_env):
327327
worker = NPUWorker()
328328
worker.local_rank = 1
329329
worker.model_config = MagicMock()
330-
worker.parallel_config = MagicMock()
331-
worker.parallel_config.local_world_size = 1
332330
worker.model_config.seed = 42
333331

334332
# Test _init_device

0 commit comments

Comments
 (0)