Skip to content

Conversation

@zhangxinyuehfad
Copy link
Contributor

@zhangxinyuehfad zhangxinyuehfad commented Nov 25, 2025

What this PR does / why we need it?

pin Transformer version to 4.57.1 fix 'dict' object has no attribute 'model_type'
https://github.com/vllm-project/vllm-ascend/actions/runs/19660859460/job/56306822464

picked from #4423

Does this PR introduce any user-facing change?

How was this patch tested?

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@vllm-ascend-ci vllm-ascend-ci added ready read for review ready-for-test start test by label for PR labels Nov 25, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes an AttributeError in the test_fused_moe E2E test by mocking is_vl_model. The approach is correct. I've suggested a small refactoring to make the patching cleaner by using string paths, which avoids unnecessary imports. Additionally, the similar test test_token_dispatcher_with_all_gather_quant appears to be unpatched and may suffer from the same issue. It would be good to apply the same fix to that test as well to ensure all tests pass reliably.

@zhangxinyuehfad zhangxinyuehfad force-pushed the zxy_v0.11.0_fix_e2e branch 2 times, most recently from 6b495ce to 8917e96 Compare November 25, 2025 07:06
@zhangxinyuehfad zhangxinyuehfad changed the title [0.11.0][Bugfix] fix test_fused_moe e2e test [0.11.0][Bugfix] fix e2e full ftest Nov 25, 2025
@wangxiyuan wangxiyuan changed the title [0.11.0][Bugfix] fix e2e full ftest [0.11.0][Bugfix] fix e2e full test Nov 25, 2025
@wangxiyuan wangxiyuan merged commit a686f29 into vllm-project:v0.11.0-dev Nov 25, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready read for review ready-for-test start test by label for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants