Merge branch 'main' into fix/2363

Author: mbokman

.github/issue_greeting_template.md

@@ -1,5 +1,5 @@
 Hello, {{ .author }}! 🖐
 
-Thank you for submitting an issue for this provider. The issue will now enter into the [issue lifecycle](https://github.com/hashicorp/terraform-provider-vsphere/blob/main/docs/ISSUES.md#issue-lifecycle).
+Thank you for submitting an issue for this provider. The issue will now enter into the [issue lifecycle](https://github.com/hashicorp/terraform-provider-vsphere/blob/main/docs/issues.md#issue-lifecycle).
 
-If you want to contribute to this project, please review the [contributing guidelines](https://github.com/hashicorp/terraform-provider-vsphere/blob/main/docs/CONTRIBUTING.md) and information on [submitting pull requests](https://github.com/hashicorp/terraform-provider-vsphere/blob/main/docs/PULL_REQUESTS.md).
+If you want to contribute to this project, please review the [contributing guidelines](https://github.com/hashicorp/terraform-provider-vsphere/blob/main/docs/CONTRIBUTING.md) and information on [submitting pull requests](https://github.com/hashicorp/terraform-provider-vsphere/blob/main/docs/pull_requests.md).

.github/workflows/golangci-lint.yml

@@ -0,0 +1,32 @@
+---
+name: golangci-lint
+
+on:
+  pull_request:
+    paths-ignore:
+      - README.md
+  push:
+    paths-ignore:
+      - README.md
+
+permissions:
+  contents: read
+
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+    timeout-minutes: 5
+    steps:
+      - name: Checkout
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+      - name: Setup Go
+        uses: actions/setup-go@0aaccfd150d50ccaeb58ebd88d36e91967a5f35b # v5.4.0
+        with:
+          go-version-file: go.mod
+          cache: true
+      - run: go mod download
+      - run: go build -v .
+      - name: Run Linters
+        uses: golangci/golangci-lint-action@1481404843c368bc19ca9406f87d6e0fc97bdcfd # v7.0.0
+        with:
+          version: latest

.go-version

@@ -1 +1 @@
-1.22.8
+1.23.8

.golangci.yml

@@ -0,0 +1,183 @@
+---
+version: "2"
+
+output:
+  formats:
+    text:
+      path: stdout
+
+linters:
+  default: none
+  enable:
+    - errcheck
+    - gosec
+    - govet
+    - ineffassign
+    - misspell
+    - revive
+    - staticcheck
+    - unconvert
+    - unused
+  settings:
+    errcheck:
+      exclude-functions:
+        - github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema:ForceNew|Set
+        - fmt:.*
+        - io:Close
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    rules:
+      # TODO: Setting temporary exclusions for specific linters.
+      - linters:
+          - errcheck
+        text: Error return value of `d.Set` is not checked
+      - linters:
+          - gosec
+        text: G107
+      - linters:
+          - gosec
+        text: G109
+      - linters:
+          - gosec
+        text: G115
+      - linters:
+          - gosec
+        text: G401
+      - linters:
+          - gosec
+        text: G402
+      - linters:
+          - gosec
+        text: G505
+      - linters:
+          - ineffassign
+        text: ineffectual assignment
+      - linters:
+          - revive
+        text: redefines-builtin-id
+      - linters:
+          - revive
+        text: unused-parameter
+      - linters:
+          - revive
+        text: var-naming
+      - linters:
+          - revive
+        text: superfluous-else
+      - linters:
+          - staticcheck
+        text: S1002
+      - linters:
+          - staticcheck
+        text: S1007
+      - linters:
+          - staticcheck
+        text: ST1007
+      - linters:
+          - staticcheck
+        text: SA1019
+      - linters:
+          - staticcheck
+        text: SA1040
+      - linters:
+          - staticcheck
+        text: SA9003
+      - linters:
+          - staticcheck
+        text: ST1005
+      - linters:
+          - staticcheck
+        text: QF1002
+      - linters:
+          - staticcheck
+        text: QF1005
+      - linters:
+          - unconvert
+        text: unnecessary conversion
+      - linters:
+          - unused
+        text: is unused
+      - linters:
+          - revive
+        text: indent-error-flow
+      - linters:
+          - revive
+        text: error-strings
+      - linters:
+          - revive
+        text: range
+      - linters:
+          - revive
+        text: exported
+      - linters:
+          - revive
+        text: empty-block
+      - linters:
+          - staticcheck
+        text: QF1008
+      - linters:
+          - staticcheck
+        text: QF1012
+      - linters:
+          - staticcheck
+        text: QF1003
+      - linters:
+          - staticcheck
+        text: SA1006
+      - linters:
+          - staticcheck
+        text: SA4006
+      - linters:
+          - staticcheck
+        text: S1009
+      - linters:
+          - staticcheck
+        text: S1017
+      - linters:
+          - staticcheck
+        text: S1039
+      - linters:
+          - staticcheck
+        text: S1040
+      - linters:
+          - staticcheck
+        text: S1005
+      - linters:
+          - goimports
+        text: File is not properly formatted
+      - linters:
+          - errcheck
+        path: vsphere/data_source_vsphere_datacenter.go
+        text: Error return value of `view.Destroy` is not checked
+      - linters:
+          - errcheck
+        path: vsphere/distributed_virtual_switch_helper.go
+        text: Error return value of `task.Wait` is not checked
+      - linters:
+          - gofmt
+        path: vsphere/resource_vsphere_compute_cluster.go
+        text: File is not properly formatted
+
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
+
+issues:
+  max-same-issues: 0
+
+formatters:
+  enable:
+    - gofmt
+    - goimports
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

.goreleaser.yml

@@ -1,12 +1,13 @@
 # Copyright (c) HashiCorp, Inc.
 # SPDX-License-Identifier: MPL-2.0
 
+version: 2
 archives:
   - files:
       # Ensure only built binary and license file are archived
       - src: 'LICENSE'
-        dst: 'LICENSE.txt'    
-    format: zip
+        dst: 'LICENSE.txt'
+    formats: ['zip']
     name_template: '{{ .ProjectName }}_{{ .Version }}_{{ .Os }}_{{ .Arch }}'
 builds:
   - # Special binary naming is only necessary for Terraform CLI 0.12
@@ -85,4 +86,4 @@ signs:
       --out ${signature}
     artifacts: checksum
 snapshot:
-  name_template: "{{ .Tag }}-next"
+  version_template: "{{ .Tag }}-next"

CHANGELOG.md

@@ -310,7 +310,7 @@ FEATURES:
 
 DOCUMENTATION:
 
-- Updated `INSTALL.md` use use `unzip` for Linux and macOS examples.
+- Updated `install.md` use use `unzip` for Linux and macOS examples.
   ([#2105](https://github.com/terraform-providers/terraform-provider-vsphere/pull/2105))
 
 CHORES:

README.md

@@ -28,7 +28,7 @@ Learn more:
   [developer.hashicorp.com][terraform-install] and
   [the project][terraform-github] on GitHub.
 
-- [Go 1.22.8][golang-install]
+- [Go 1.23.8][golang-install]
 
   Required if building the provider.
 
@@ -93,9 +93,9 @@ The Terraform Provider for VMware vSphere is available under the
 [provider-contributing]: docs/CONTRIBUTING.md
 [provider-discussions]: https://discuss.hashicorp.com/tags/c/terraform-providers/31/vsphere
 [provider-documentation]: https://registry.terraform.io/providers/hashicorp/vsphere/latest/docs
-[provider-faq]: docs/FAQ.md
-[provider-install]: docs/INSTALL.md
-[provider-issue-lifecycle]: docs/ISSUES.md
+[provider-faq]: docs/faq.md
+[provider-install]: docs/install.md
+[provider-issue-lifecycle]: docs/issues.md
 [provider-issues]: https://github.com/hashicorp/terraform-provider-vsphere/issues/new/choose
 [provider-license]: LICENSE
 [terraform-github]: https://github.com/hashicorp/terraform

docs/CONTRIBUTING.md

@@ -13,8 +13,8 @@ It's the best entry point if you are new to contributing to this provider.
 To learn more about how to create issues and pull requests in this repository,
 and what happens after they are created, you may refer to the resources below:
 
-- [Issue Creation and Lifecycle](ISSUES.md)
-- [Pull Request Creation and Lifecycle](PULL_REQUESTS.md)
+- [Issue Creation and Lifecycle](issues.md)
+- [Pull Request Creation and Lifecycle](pull_requests.md)
 
 ## Cloning the Project
 

website/docs/d/compute_cluster.html.markdown renamed to docs/data-sources/compute_cluster.md

@@ -1,14 +1,13 @@
 ---
 subcategory: "Host and Cluster Management"
-layout: "vsphere"
 page_title: "VMware vSphere: vsphere_compute_cluster"
 sidebar_current: "docs-vsphere-data-source-compute-cluster"
 description: |-
   Provides a vSphere cluster data source. This can be used to get the general
   attributes of a vSphere cluster.
 ---
 
-# vsphere\_compute\_cluster
+# vsphere_compute_cluster
 
 The `vsphere_compute_cluster` data source can be used to discover the ID of a
 cluster in vSphere. This is useful to fetch the ID of a cluster that you want to
@@ -51,12 +50,12 @@ The following arguments are supported:
   absolute path. For default datacenters, use the `id` attribute from an empty
   `vsphere_datacenter` data source.
 
-[docs-about-morefs]: /docs/providers/vsphere/index.html#use-of-managed-object-references-by-the-vsphere-provider
-
 ## Attribute Reference
 
 The following attributes are exported:
 
 * `id`: The [managed object reference ID][docs-about-morefs] of the cluster.
 * `resource_pool_id`: The [managed object reference ID][docs-about-morefs] of
   the root resource pool for the cluster.
+
+[docs-about-morefs]: /docs/providers/vsphere/index.html#use-of-managed-object-references-by-the-vsphere-provider

website/docs/d/compute_cluster_host_group.html.markdown renamed to docs/data-sources/compute_cluster_host_group.md

@@ -1,14 +1,13 @@
 ---
 subcategory: "Host and Cluster Management"
-layout: "vsphere"
 page_title: "VMware vSphere: vsphere_compute_cluster_host_group"
 sidebar_current: "docs-vsphere-data-source-compute-cluster-host-group"
 description: |-
   Provides a vSphere cluster host group data source. Returns attributes of a
   vSphere cluster host group.
 ---
 
-# vsphere\_compute\_cluster\_host\_group
+# vsphere_compute_cluster_host_group
 
 The `vsphere_compute_cluster_host_group` data source can be used to discover
 the IDs ESXi hosts in a host group and return host group attributes to other
@@ -48,9 +47,9 @@ The following arguments are supported:
   [managed object reference ID][docs-about-morefs] of the compute cluster for
   the host group.
 
-[docs-about-morefs]: /docs/providers/vsphere/index.html#use-of-managed-object-references-by-the-vsphere-provider
-
 ## Attribute Reference
 
 * `host_system_ids`: The [managed object reference ID][docs-about-morefs] of
   the ESXi hosts in the host group.
+
+[docs-about-morefs]: /docs/providers/vsphere/index.html#use-of-managed-object-references-by-the-vsphere-provider