Skip to content

Conversation

@spacegospod
Copy link
Contributor

@spacegospod spacegospod commented Dec 1, 2025

Summary

Adding the capability to set num_cores_per_socket to 0 which means that the value will be determined automatically when the virtual machine is powered on.
Also adding num_cores_per_numa_node which behaves like num_cores_per_socket but affects the NUMA configuration as opposed to the actual core count.

vmware/govmomi#3906

Type

  • fix: Bug Fix
  • feat: Feature or Enhancement
  • docs: Documentation
  • refactor: Refactoring
  • chore: Build, Dependencies, Workflows, etc.
  • other: Other (Please describe.)

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Tests

  • Tests have been added or updated.
  • Tests have been completed.

Output:

✅ TestAccDataSourceVSphereDatacenter_getVirtualMachines (14.02s)
✅ TestAccDataSourceVSphereVirtualMachine_basic (9.19s)
✅ TestAccDataSourceVSphereVirtualMachine_moid (14.49s)
✅ TestAccDataSourceVSphereVirtualMachine_nameAndFolder (14.85s)
✅ TestAccDataSourceVSphereVirtualMachine_noDatacenterAndAbsolutePath (15.21s)
✅ TestAccDataSourceVSphereVirtualMachine_uuid (15.05s)
✅ TestAccResourceVSphereVirtualMachine_basic (17.06s)
✅ TestAccResourceVSphereVirtualMachine_cpuTopology (48.34s)
✅ TestAccResourceVSphereVirtualMachine_deployOvaFromUrl (26.57s)
✅ TestAccResourceVSphereVirtualMachine_hardwareVersionBare (14.66s)
✅ TestAccResourceVSphereVirtualMachine_hardwareVersionClone (56.74s)
✅ TestAccResourceVSphereVirtualMachine_hardwareVersionUpgrade (31.73s)
✅ TestAccResourceVSphereVirtualMachine_highDiskUnitNumbers (15.91s)
✅ TestAccResourceVSphereVirtualMachine_highDiskUnitsToRegularSingleController (38.95s)
✅ TestAccResourceVSphereVirtualMachine_ignoreValidationOnComputedValue (1.33s)
✅ TestAccResourceVSphereVirtualMachine_moveToFolder (20.81s)
✅ TestAccResourceVSphereVirtualMachine_multiDevice (15.76s)
✅ TestAccResourceVSphereVirtualMachine_reCreateOnDeletion (23.17s)
✅ TestAccResourceVSphereVirtualMachine_removeMiddleDevices (28.25s)
✅ TestAccResourceVSphereVirtualMachine_removeMiddleDevicesChangeDiskUnit (32.62s)
✅ TestAccResourceVSphereVirtualMachine_scsiBusSharing (54.14s)
✅ TestAccResourceVSphereVirtualMachine_scsiBusSharingUpdate (1m10.92s)
✅ TestAccResourceVSphereVirtualMachine_shutdownOK (15.96s)

Documentation

  • Documentation has been added or updated.

Issue References

Resolves #2532

Release Note

- `r/virtual_machine` - Support CPU topology assigned at power on

Additional Information

…port for numa node config

Signed-off-by: Stoyan Zhelyazkov <[email protected]>
@spacegospod spacegospod requested a review from a team as a code owner December 1, 2025 14:07
@github-actions github-actions bot added documentation Documentation provider Provider needs-review Needs Review size/l Relative Sizing: Large labels Dec 1, 2025
@spacegospod spacegospod self-assigned this Dec 1, 2025
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple HCL formatting nits but otherwise, LGTM!

@tenthirtyam tenthirtyam added this to the v2.16.0 milestone Dec 1, 2025
@tenthirtyam tenthirtyam removed the needs-review Needs Review label Dec 1, 2025
@github-actions github-actions bot added the needs-review Needs Review label Dec 1, 2025
@tenthirtyam tenthirtyam removed the needs-review Needs Review label Dec 1, 2025
@tenthirtyam tenthirtyam merged commit c0a3a69 into main Dec 1, 2025
9 checks passed
@tenthirtyam tenthirtyam deleted the feat/cpu-topology branch December 1, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Documentation provider Provider size/l Relative Sizing: Large

Projects

None yet

Development

Successfully merging this pull request may close these issues.

r/virtual_machine: add support to set CPU topology to assigned at power on

3 participants