feat: r/virtual_machine support CPU Topology assigned at power on
#2636
+168
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding the capability to set
num_cores_per_socketto0which means that the value will be determined automatically when the virtual machine is powered on.Also adding
num_cores_per_numa_nodewhich behaves likenum_cores_per_socketbut affects the NUMA configuration as opposed to the actual core count.vmware/govmomi#3906
Type
fix: Bug Fixfeat: Feature or Enhancementdocs: Documentationrefactor: Refactoringchore: Build, Dependencies, Workflows, etc.other: Other (Please describe.)Breaking Changes?
Tests
Output:
✅ TestAccDataSourceVSphereDatacenter_getVirtualMachines (14.02s)
✅ TestAccDataSourceVSphereVirtualMachine_basic (9.19s)
✅ TestAccDataSourceVSphereVirtualMachine_moid (14.49s)
✅ TestAccDataSourceVSphereVirtualMachine_nameAndFolder (14.85s)
✅ TestAccDataSourceVSphereVirtualMachine_noDatacenterAndAbsolutePath (15.21s)
✅ TestAccDataSourceVSphereVirtualMachine_uuid (15.05s)
✅ TestAccResourceVSphereVirtualMachine_basic (17.06s)
✅ TestAccResourceVSphereVirtualMachine_cpuTopology (48.34s)
✅ TestAccResourceVSphereVirtualMachine_deployOvaFromUrl (26.57s)
✅ TestAccResourceVSphereVirtualMachine_hardwareVersionBare (14.66s)
✅ TestAccResourceVSphereVirtualMachine_hardwareVersionClone (56.74s)
✅ TestAccResourceVSphereVirtualMachine_hardwareVersionUpgrade (31.73s)
✅ TestAccResourceVSphereVirtualMachine_highDiskUnitNumbers (15.91s)
✅ TestAccResourceVSphereVirtualMachine_highDiskUnitsToRegularSingleController (38.95s)
✅ TestAccResourceVSphereVirtualMachine_ignoreValidationOnComputedValue (1.33s)
✅ TestAccResourceVSphereVirtualMachine_moveToFolder (20.81s)
✅ TestAccResourceVSphereVirtualMachine_multiDevice (15.76s)
✅ TestAccResourceVSphereVirtualMachine_reCreateOnDeletion (23.17s)
✅ TestAccResourceVSphereVirtualMachine_removeMiddleDevices (28.25s)
✅ TestAccResourceVSphereVirtualMachine_removeMiddleDevicesChangeDiskUnit (32.62s)
✅ TestAccResourceVSphereVirtualMachine_scsiBusSharing (54.14s)
✅ TestAccResourceVSphereVirtualMachine_scsiBusSharingUpdate (1m10.92s)
✅ TestAccResourceVSphereVirtualMachine_shutdownOK (15.96s)
Documentation
Issue References
Resolves #2532
Release Note
Additional Information