Skip to content

Commit 375bd6e

Browse files
authored
refactor: use a log instead (#57)
refactor: use a log instead for deferred vol deletion
1 parent 592903c commit 375bd6e

File tree

1 file changed

+5
-10
lines changed

1 file changed

+5
-10
lines changed

internal/engine/services/worker/service.go

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -219,22 +219,17 @@ func (s *Service) runTask(ctx context.Context, t *task.Task) error {
219219
createdVolumeSpan.End()
220220

221221
defer func(volName string) {
222-
ctx, deleteVolumeSpan := s.tracer.Start(context.Background(), "Delete Volume Deferred", trace.WithAttributes(
223-
attribute.String("volume.name", volName),
224-
))
225-
defer deleteVolumeSpan.End()
226-
227222
opts := []runner.DeleteVolumeOption{
228223
runner.DeleteVolumeWithName(volName),
229224
}
230225

226+
ctx := context.Background()
227+
231228
if err := s.runner.DeleteVolume(ctx, opts...); err != nil {
232-
deleteVolumeSpan.RecordError(err)
233-
deleteVolumeSpan.SetStatus(codes.Error, err.Error())
234-
slog.ErrorContext(ctx, "failed to delete volume", "name", volName)
229+
slog.ErrorContext(ctx, "failed to delete volume", "name", volName, "error", err)
230+
} else {
231+
slog.InfoContext(ctx, "volume deleted", "name", volName)
235232
}
236-
237-
deleteVolumeSpan.SetStatus(codes.Ok, "volume deleted")
238233
}(volName)
239234

240235
ms = append(ms, &task.Mount{

0 commit comments

Comments
 (0)