Fix: Align Cache API definitions with Storage spec #1789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit clarifies how the Cache API interacts with the underlying storage mechanism, resolving ambiguity that stemmed from previous specification language. Key changes: - Removes the direct association between "storage key" and "name to cache map". - Defines "relevant name to cache map" as being retrieved via the `obtain a local storage bottle map` algorithm from the Storage specification, ensuring alignment. - Updates the definition of `CacheStorage` to represent the `name to cache map` associated with its `environment settings object`, rather than the `origin`. This makes the relationship between the ServiceWorker Cache API and the Storage specification explicit and consistent, addressing the core issue raised in w3c#1784 and the follow-up work in w3c#1788.
|
@annevk @mkruisselbrink @wanderview FYI. |
|
Looks reasonable to me, but my spec knowledge is a bit rusty. |
monica-ch
reviewed
Sep 5, 2025
monica-ch
reviewed
Sep 6, 2025
monica-ch
reviewed
Sep 6, 2025
domenic
reviewed
Sep 8, 2025
Addresses review comments by: - Clarifying the definition of "relevant name to cache map" and its relationship with `CacheStorage`. - Removing the explicit ID and avoiding indirect `[=this=]` usage. - Ensuring consistent syntax for `[=name to cache map=]` references.
monica-ch
approved these changes
Sep 9, 2025
github-actions bot
added a commit
that referenced
this pull request
Sep 10, 2025
SHA: e3403ed Reason: push, by yoshisatoyanagisawa Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to yoshisatoyanagisawa/ServiceWorker
that referenced
this pull request
Sep 10, 2025
SHA: e3403ed Reason: push, by yoshisatoyanagisawa Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to asleekgeek/ServiceWorker
that referenced
this pull request
Sep 10, 2025
SHA: e3403ed Reason: push, by pull[bot] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit clarifies how the Cache API interacts with the underlying storage mechanism, resolving ambiguity that stemmed from previous specification language.
Key changes:
obtain a local storage bottle mapalgorithm from the Storage specification, ensuring alignment.CacheStorageto represent thename to cache mapassociated with itsenvironment settings object, rather than theorigin.This makes the relationship between the ServiceWorker Cache API and the Storage specification explicit and consistent, addressing the core issue raised in #1784 and the follow-up work in #1788.
Preview | Diff