Incidentally, in other news (and for the record here) — I’m making some (hopefully non-breaking) changes (just additions, really) to the install stuff and API for the vnu-jar package. See validator/validator#1972

As documented in the updated npm.md there (the source for the package README), the changes are that the package will:

Run a postinstall step which — if it finds no java command in the user’s environment during install — will then automatically install a (Node.js-local) Java runtime environment, in node_modules/.cache/vnu-jar/java/).
Expose an npx-runnable vnu command — for doing, e.g., npx vnu index.html.

Expose an additional new check() function, so that code can just do this:

const { vnu } = require('vnu-jar');
const source = process.argv[2];
if (!source) {
    console.error('Usage: node vnu-check.js <source>');
    process.exit(1);
}
(async () => {
    try {
        await vnu.check([source]);
        console.log('✅ No problems found!');
    } catch {
        console.error('❌ Problems found.');
        process.exit(1);
    }
})();

But, as far as I can tell, none of those changes should actually affect spec-prod at all. Specifically:

spec-prod wouldn’t need to use the { vnu } export and check() function, but could instead just keep using the default export (to get the vnu.jar path)
because spec-prod running under CI already installs a Java environment — with a java command — the new postinstall step will essentially just be a no-op for spec-prod

Of course if we wanted to switch spec-prod to using that new API, I guess we could — but it’s really just intended for use cases where we don’t know ahead of time whether there’s already an installed Java runtime in the environment. But since with spec-prod, running under CI, we can guarantee that a Java runtime is already installed — before npm install vnu-jar gets called — then it seems like there’d be no real need/benefit for spec-prod to switch to using that new API.

Latest version of vnu.jar #215

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions