wasm3: freemodule is needed if loadmodule fails

axic · axic · commit 0505fed8a9e7 · 2022-05-20T12:53:03.000+02:00
diff --git a/test/utils/wasm3_engine.cpp b/test/utils/wasm3_engine.cpp
@@ -85,7 +85,7 @@ bool Wasm3Engine::instantiate(bytes_view wasm_binary)
     // Transfers ownership to runtime.
     if (m3_LoadModule(m_runtime, module) != m3Err_none)
     {
-        // NOTE: apparently m3_FreeModule isn't needed in neither the failure nor the success case
+        m3_FreeModule(module);
         return false;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ bool Wasm3Engine::instantiate(bytes_view wasm_binary)`
`85`	`85`	`// Transfers ownership to runtime.`
`86`	`86`	`if (m3_LoadModule(m_runtime, module) != m3Err_none)`
`87`	`87`	`{`
`88`		`- // NOTE: apparently m3_FreeModule isn't needed in neither the failure nor the success case`
	`88`	`+ m3_FreeModule(module);`
`89`	`89`	`return false;`
`90`	`90`	`}`
`91`	`91`