Skip to content

Conversation

@maboiteaspam
Copy link

Add an example file example.js which demonstrates more about the library
Changed Bonjour.findOne method to add opts.timeout support

@maboiteaspam
Copy link
Author

Hi!
I have also added some debug message support at https://github.com/maboiteaspam/bonjour/tree/patch-1 (bonjour --verbose multicast-dns,bonjour)
but not compatible with node 0.10, so yeah did not want to pollute your prs.

edit: awesome lib !

@watson
Copy link
Owner

watson commented Jan 4, 2016

Hi @maboiteaspam

Thanks a lot for the pull request 😃 In the future it would have been better if you'd split this up into two separate PR's as the two commits have nothing to do with each other. That would make each easier to discuss.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would make more sense to just call the callback without any arguments instead of false in case the timeout happens

@watson
Copy link
Owner

watson commented May 6, 2016

@maboiteaspam ping 😃

xploSEoF added a commit to Event-Engineering/bonjour that referenced this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants