Skip to content

Commit a3ad6db

Browse files
authored
GitHub: Upgrade GitHub actions that depend on deprecated Node.js versions (ni#15)
- [x] This contribution adheres to [CONTRIBUTING.md](https://github.com/ni/nisync-python/blob/main/CONTRIBUTING.md). ### What does this Pull Request accomplish? 1. Upgrade setup-python to v5 2. Upgrade upload/download-artifact to v4 3. Upgrade Gr1N/setup-poetry v9 4. Upgrade actions/checkout to v4 5. Rename test_results files and merge it ### Why should this Pull Request be merged? To resolve: https://github.com/ni/nisync-python/actions/runs/10628769806 The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-python@v4, Gr1N/setup-poetry@v8. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/ ### What testing has been done? PR build --------- Signed-off-by: wchung <[email protected]>
1 parent 5fab7a3 commit a3ad6db

File tree

4 files changed

+10
-9
lines changed

4 files changed

+10
-9
lines changed

.github/workflows/build.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@ jobs:
1212
- name: Check out repo
1313
uses: actions/checkout@v4
1414
- name: Set up Python
15-
uses: actions/setup-python@v4
15+
uses: actions/setup-python@v5
1616
with:
1717
# The codegen scripts require Python 3.8 or later.
1818
python-version: "3.8"
1919
- name: Set up Poetry
20-
uses: Gr1N/setup-poetry@v8
20+
uses: Gr1N/setup-poetry@v9
2121
with:
2222
poetry-version: "1.8.3"
2323
- name: Check Poetry version

.github/workflows/report_test_results.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,11 @@ jobs:
1818
- name: Check out repo
1919
uses: actions/checkout@v4
2020
- name: Download test results
21-
uses: actions/download-artifact@v3
21+
uses: actions/download-artifact@v4
2222
with:
23-
name: test_results
2423
path: test_results
24+
pattern: test_results_*
25+
merge-multiple: true
2526
- name: List downloaded files
2627
run: ls -lR
2728
- name: Publish test results

.github/workflows/run_acceptance_tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
timeout-minutes: 90
2222
steps:
2323
- name: Check out repo
24-
uses: actions/checkout@v3
24+
uses: actions/checkout@v4
2525
- name: Install dependencies
2626
run: poetry install
2727
- name: Run acceptance tests for PXIe-6674T

.github/workflows/run_unit_tests.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,11 @@ jobs:
1919
- name: Check out repo
2020
uses: actions/checkout@v4
2121
- name: Set up Python ${{ matrix.python-version }}
22-
uses: actions/setup-python@v4
22+
uses: actions/setup-python@v5
2323
with:
2424
python-version: ${{ matrix.python-version }}
2525
- name: Set up Poetry
26-
uses: Gr1N/setup-poetry@v8
26+
uses: Gr1N/setup-poetry@v9
2727
with:
2828
poetry-version: "1.8.3"
2929
- name: Check Poetry version
@@ -37,8 +37,8 @@ jobs:
3737
- name: Run unit tests
3838
run: poetry run pytest -v --junitxml=test_results/unit-${{ matrix.os }}-py${{ matrix.python-version }}.xml
3939
- name: Upload test results
40-
uses: actions/upload-artifact@v3
40+
uses: actions/upload-artifact@v4
4141
with:
42-
name: test_results
42+
name: test_results_unit_${{ matrix.os }}_py${{ matrix.python-version }}
4343
path: test_results/*.xml
4444
if: always()

0 commit comments

Comments
 (0)