fix(moduleFederation): remove split chunks patch (#6572)

Author: chenjiahan

packages/core/src/plugins/moduleFederation.ts

@@ -1,92 +1,5 @@
-import { isRegExp } from 'node:util/types';
-import type { RspackPluginInstance } from '@rspack/core';
 import { rspack } from '../rspack';
-import type { RsbuildPlugin, Rspack } from '../types';
-
-/**
- * Force remote entry not be affected by user's chunkSplit strategy,
- * Otherwise, the remote chunk will not be loaded correctly.
- * @see https://github.com/web-infra-dev/rsbuild/discussions/1461#discussioncomment-8329790
- */
-class PatchSplitChunksPlugin implements RspackPluginInstance {
-  name: string;
-
-  constructor(name: string) {
-    this.name = name;
-  }
-
-  apply(compiler: Rspack.Compiler): void {
-    const { splitChunks } = compiler.options.optimization;
-
-    if (!splitChunks) {
-      return;
-    }
-
-    const applyPatch = (
-      config:
-        | Rspack.OptimizationSplitChunksCacheGroup
-        | Rspack.OptimizationSplitChunksOptions,
-    ) => {
-      if (typeof config !== 'object' || isRegExp(config)) {
-        return;
-      }
-
-      // cacheGroup.chunks will inherit splitChunks.chunks
-      // so we only need to modify the chunks that are set separately.
-      const { chunks } = config;
-      if (!chunks || chunks === 'async') {
-        return;
-      }
-
-      if (typeof chunks === 'function') {
-        const prevChunks = chunks;
-
-        config.chunks = (chunk) => {
-          if (chunk.name && chunk.name === this.name) {
-            return false;
-          }
-          return prevChunks(chunk);
-        };
-        return;
-      }
-
-      if (chunks === 'all') {
-        config.chunks = (chunk) => {
-          if (chunk.name && chunk.name === this.name) {
-            return false;
-          }
-          return true;
-        };
-        return;
-      }
-
-      if (chunks === 'initial') {
-        config.chunks = (chunk) => {
-          if (chunk.name && chunk.name === this.name) {
-            return false;
-          }
-          return chunk.isOnlyInitial();
-        };
-        return;
-      }
-    };
-
-    // patch splitChunk.chunks
-    applyPatch(splitChunks);
-
-    const { cacheGroups } = splitChunks;
-    if (!cacheGroups) {
-      return;
-    }
-
-    // patch splitChunk.cacheGroups[key].chunks
-    for (const cacheGroupKey of Object.keys(cacheGroups)) {
-      if (cacheGroups[cacheGroupKey]) {
-        applyPatch(cacheGroups[cacheGroupKey]);
-      }
-    }
-  }
-}
+import type { RsbuildPlugin } from '../types';
 
 export function pluginModuleFederation(): RsbuildPlugin {
   return {
@@ -177,12 +90,6 @@ export function pluginModuleFederation(): RsbuildPlugin {
           .use(rspack.container.ModuleFederationPlugin, [options]);
 
         if (options.name) {
-          if (options.exposes) {
-            chain
-              .plugin('mf-patch-split-chunks')
-              .use(PatchSplitChunksPlugin, [options.name]);
-          }
-
           // `uniqueName` is required for react refresh to work
           if (!chain.output.get('uniqueName')) {
             chain.output.set('uniqueName', options.name);

packages/core/tests/__snapshots__/moduleFederation.test.ts.snap

@@ -35,9 +35,6 @@ exports[`plugin-module-federation > should set environment module federation con
           },
         },
       },
-      PatchSplitChunksPlugin {
-        "name": "remote",
-      },
     ],
   },
   {
@@ -97,9 +94,6 @@ exports[`plugin-module-federation > should set module federation and environment
           },
         },
       },
-      PatchSplitChunksPlugin {
-        "name": "remote",
-      },
     ],
   },
   {
@@ -132,9 +126,6 @@ exports[`plugin-module-federation > should set module federation and environment
           },
         },
       },
-      PatchSplitChunksPlugin {
-        "name": "remote",
-      },
     ],
   },
 ]
@@ -174,9 +165,6 @@ exports[`plugin-module-federation > should set module federation config 1`] = `
         },
       },
     },
-    PatchSplitChunksPlugin {
-      "name": "remote",
-    },
   ],
 }
 `;

website/docs/en/config/module-federation/options.mdx

@@ -19,7 +19,6 @@ When you set the `moduleFederation.options` option, Rsbuild will take the follow
 - Set the default value of the provider's [dev.assetPrefix](/config/dev/asset-prefix) configuration to `true`. This will ensure that the static asset URL is correct for remote modules.
 - Set the default value of Rspack's [output.uniqueName](https://rspack.rs/config/output#outputuniquename) configuration to `moduleFederation.options.name`, this allows HMR to work as expected.
 - Turn off the `split-by-experience` rules in Rsbuild's [performance.chunkSplit](/config/performance/chunk-split) as it may conflict with shared modules, refer to [#3161](https://github.com/module-federation/module-federation-examples/issues/3161).
-- Turn off the splitChunks rule of remote entry.
 
 ## Usage
 

website/docs/zh/config/module-federation/options.mdx

@@ -19,7 +19,6 @@
 - 将 provider 的 [dev.assetPrefix](/config/dev/asset-prefix) 配置的默认值设置为 `true`，这可以确保 remote modules 的静态资源 URL 是正确的。
 - 将 Rspack [output.uniqueName](https://rspack.rs/zh/config/output#outputuniquename) 配置的默认值设置为 `moduleFederation.options.name`，使 HMR 可以正常工作。
 - 关闭 Rsbuild [performance.chunkSplit](/config/performance/chunk-split) 中 `split-by-experience` 相关的规则，因为这可能会与 shared modules 冲突，参考 [#3161](https://github.com/module-federation/module-federation-examples/issues/3161)。
-- 关闭 remote entry 的 splitChunks 规则。
 
 ## 用法