Skip to content

Conversation

@chenjiahan
Copy link
Member

Summary

This PR revert some changes of #3750, because it is a potentially breaking change for html-webpack-plugin <= 5.6.0 projects, such as Modern.js (web-infra-dev/modern.js#6402).

We can use the getCompilationHooks API in Rsbuild minor releases.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 8a951fc
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/6711dbf65701d20008415f82
😎 Deploy Preview https://deploy-preview-3753--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 53 (🔴 down 9 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit 454d046 into main Oct 18, 2024
8 checks passed
@chenjiahan chenjiahan deleted the get_hooks_1018 branch October 18, 2024 05:51
@chenjiahan chenjiahan mentioned this pull request Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants