From e4fafcb08a31c772a80a5a0eeffe47ccf51d59d5 Mon Sep 17 00:00:00 2001 From: neverland Date: Fri, 18 Oct 2024 11:47:26 +0800 Subject: [PATCH 1/2] fix: revert to the `getHooks` of HTML plugin --- packages/core/src/rspack/RsbuildHtmlPlugin.ts | 2 +- .../core/src/rspack/preload/HtmlPreloadOrPrefetchPlugin.ts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/core/src/rspack/RsbuildHtmlPlugin.ts b/packages/core/src/rspack/RsbuildHtmlPlugin.ts index b0b5a9b99e..40886b20a7 100644 --- a/packages/core/src/rspack/RsbuildHtmlPlugin.ts +++ b/packages/core/src/rspack/RsbuildHtmlPlugin.ts @@ -310,7 +310,7 @@ export class RsbuildHtmlPlugin { compiler.hooks.compilation.tap(this.name, (compilation: Compilation) => { getHTMLPlugin() - .getCompilationHooks(compilation) + .getHooks(compilation) .alterAssetTagGroups.tapPromise(this.name, async (data) => { const entryName = data.plugin.options?.entryName; diff --git a/packages/core/src/rspack/preload/HtmlPreloadOrPrefetchPlugin.ts b/packages/core/src/rspack/preload/HtmlPreloadOrPrefetchPlugin.ts index e14619c16e..7acb17278a 100644 --- a/packages/core/src/rspack/preload/HtmlPreloadOrPrefetchPlugin.ts +++ b/packages/core/src/rspack/preload/HtmlPreloadOrPrefetchPlugin.ts @@ -189,7 +189,7 @@ export class HtmlPreloadOrPrefetchPlugin implements RspackPluginInstance { apply(compiler: Compiler): void { compiler.hooks.compilation.tap(this.constructor.name, (compilation) => { getHTMLPlugin() - .getCompilationHooks(compilation) + .getHooks(compilation) .beforeAssetTagGeneration.tap( `HTML${upperFirst(this.type)}Plugin`, (htmlPluginData) => { @@ -206,7 +206,7 @@ export class HtmlPreloadOrPrefetchPlugin implements RspackPluginInstance { ); getHTMLPlugin() - .getCompilationHooks(compilation) + .getHooks(compilation) .alterAssetTags.tap( `HTML${upperFirst(this.type)}Plugin`, (htmlPluginData) => { From 8a951fc53ab1e3160b7192ed1816e67612033956 Mon Sep 17 00:00:00 2001 From: neverland Date: Fri, 18 Oct 2024 11:47:49 +0800 Subject: [PATCH 2/2] chore --- packages/core/src/rspack/RsbuildHtmlPlugin.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/core/src/rspack/RsbuildHtmlPlugin.ts b/packages/core/src/rspack/RsbuildHtmlPlugin.ts index 40886b20a7..7c614c4679 100644 --- a/packages/core/src/rspack/RsbuildHtmlPlugin.ts +++ b/packages/core/src/rspack/RsbuildHtmlPlugin.ts @@ -310,6 +310,7 @@ export class RsbuildHtmlPlugin { compiler.hooks.compilation.tap(this.name, (compilation: Compilation) => { getHTMLPlugin() + // TODO: use getCompilationHooks in minor release .getHooks(compilation) .alterAssetTagGroups.tapPromise(this.name, async (data) => { const entryName = data.plugin.options?.entryName;