Skip to content

Commit 25d52d8

Browse files
authored
feat!: use 'commonjs-import' as CJS external type by default (#438)
1 parent 17f7c6e commit 25d52d8

File tree

19 files changed

+176
-157
lines changed

19 files changed

+176
-157
lines changed

examples/module-federation/mf-host/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
},
1414
"devDependencies": {
1515
"@module-federation/rsbuild-plugin": "^0.7.5",
16-
"@rsbuild/core": "~1.1.3",
16+
"@rsbuild/core": "~1.1.4",
1717
"@rsbuild/plugin-react": "^1.0.7",
1818
"@types/react": "^18.3.12",
1919
"@types/react-dom": "^18.3.1",

examples/module-federation/mf-remote/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
},
1414
"devDependencies": {
1515
"@module-federation/rsbuild-plugin": "^0.7.5",
16-
"@rsbuild/core": "~1.1.3",
16+
"@rsbuild/core": "~1.1.4",
1717
"@rsbuild/plugin-react": "^1.0.7",
1818
"@types/react": "^18.3.12",
1919
"@types/react-dom": "^18.3.1",

packages/core/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
"prebundle": "prebundle"
3838
},
3939
"dependencies": {
40-
"@rsbuild/core": "~1.1.3",
40+
"@rsbuild/core": "~1.1.4",
4141
"rsbuild-plugin-dts": "workspace:*",
4242
"tinyglobby": "^0.2.10"
4343
},

packages/core/src/config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -685,7 +685,7 @@ const composeExternalsConfig = (
685685

686686
const externalsTypeMap = {
687687
esm: 'module-import',
688-
cjs: 'commonjs',
688+
cjs: 'commonjs-import',
689689
umd: 'umd',
690690
// If use 'var', when projects import an external package like '@pkg', this will cause a syntax error such as 'var pkg = @pkg'.
691691
// If use 'umd', the judgement conditions may be affected by other packages that define variables like 'define'.

packages/core/tests/__snapshots__/config.test.ts.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -396,7 +396,7 @@ exports[`Should compose create Rsbuild config correctly > Merge Rsbuild config 1
396396
},
397397
},
398398
{
399-
"externalsType": "commonjs",
399+
"externalsType": "commonjs-import",
400400
"module": {
401401
"parser": {
402402
"javascript": {

packages/create-rslib/fragments/tools/storybook-react-js/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"storybook": "storybook dev"
55
},
66
"devDependencies": {
7-
"@rsbuild/core": "~1.1.3",
7+
"@rsbuild/core": "~1.1.4",
88
"@storybook/addon-essentials": "^8.4.4",
99
"@storybook/addon-interactions": "^8.4.4",
1010
"@storybook/addon-links": "^8.4.4",

packages/create-rslib/fragments/tools/storybook-react-ts/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"storybook": "storybook dev"
55
},
66
"devDependencies": {
7-
"@rsbuild/core": "~1.1.3",
7+
"@rsbuild/core": "~1.1.4",
88
"@storybook/addon-essentials": "^8.4.4",
99
"@storybook/addon-interactions": "^8.4.4",
1010
"@storybook/addon-links": "^8.4.4",

packages/create-rslib/template-[react]-[storybook,vitest]-js/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
"test": "vitest run"
2020
},
2121
"devDependencies": {
22-
"@rsbuild/core": "~1.1.3",
22+
"@rsbuild/core": "~1.1.4",
2323
"@rsbuild/plugin-react": "^1.0.7",
2424
"@rslib/core": "workspace:*",
2525
"@storybook/addon-essentials": "^8.4.4",

packages/create-rslib/template-[react]-[storybook,vitest]-ts/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
"test": "vitest run"
2222
},
2323
"devDependencies": {
24-
"@rsbuild/core": "~1.1.3",
24+
"@rsbuild/core": "~1.1.4",
2525
"@rsbuild/plugin-react": "^1.0.7",
2626
"@rslib/core": "workspace:*",
2727
"@storybook/addon-essentials": "^8.4.4",

packages/create-rslib/template-[react]-[storybook]-js/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
"storybook": "storybook dev"
1919
},
2020
"devDependencies": {
21-
"@rsbuild/core": "~1.1.3",
21+
"@rsbuild/core": "~1.1.4",
2222
"@rsbuild/plugin-react": "^1.0.7",
2323
"@rslib/core": "workspace:*",
2424
"@storybook/addon-essentials": "^8.4.4",

0 commit comments

Comments
 (0)