Skip to content

Commit 25d47f8

Browse files
authored
Merge pull request #1320 from well-typed/dom/1074/terminology
Ensure correct usage of terminology
2 parents e3bfcbb + 08a784c commit 25d47f8

File tree

24 files changed

+150
-135
lines changed

24 files changed

+150
-135
lines changed

dev/nomenclature.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
Since we use various types of predicates, we agree on the following
2+
nomenclature:
3+
4+
- In the `Parse` pass, we either _succeed_, _do not attempt_, or _fail_ to parse
5+
a declaration.
6+
- In the `Select` pass, we either _select_ or _deselect_ a declaration.
7+
- Prescriptive binding specifications can _omit_ types; a declaration can be
8+
_extern_ due to an external binding specification.
9+
10+
In particular,
11+
- we avoid the terms _exclude_, and _skip_.
12+
- we use the term _omit_ exclusively for the effect of prescriptive binding
13+
specifications.

hs-bindgen/app/HsBindgen/App.hs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -458,7 +458,7 @@ parseProgramSlicing =
458458
, " Select declarations using the select predicate,"
459459
, " and also select their transitive dependencies;"
460460
, " program slicing can cause declarations to be included"
461-
, " even if they are explicitly excluded by a select predicate"
461+
, " even if they are explicitly deselected by a select predicate"
462462
]
463463
]
464464

hs-bindgen/app/hs-bindgen-cli.hs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ selectSliceFooter = Help.vcat [
150150
, " select declarations using the select predicate,"
151151
, " and also select their transitive dependencies;"
152152
, " program slicing can cause declarations to be included"
153-
, " even if they are explicitly excluded by a select predicate"
153+
, " even if they are explicitly deselected by a select predicate"
154154
]
155155
]
156156

0 commit comments

Comments
 (0)