Remove possibility to create external binding specs from TH mode

Author: dschrempf

hs-bindgen/app/HsBindgen/App.hs

@@ -161,7 +161,6 @@ parseConfig = Config
     <*> parseSelectPredicate
     <*> parseProgramSlicing
     <*> parsePathStyle
-    <*> optional parseGenBindingSpec
 
 {-------------------------------------------------------------------------------
   Binding specifications

hs-bindgen/app/HsBindgen/Cli/Preprocess.hs

@@ -39,13 +39,14 @@ info = progDesc "Generate Haskell module from C headers"
 -------------------------------------------------------------------------------}
 
 data Opts = Opts {
-      config          :: Config
-    , uniqueId        :: UniqueId
-    , hsModuleName    :: Hs.ModuleName
-    , hsOutputDir     :: FilePath
-    , outputDirPolicy :: OutputDirPolicy
+      config            :: Config
+    , uniqueId          :: UniqueId
+    , hsModuleName      :: Hs.ModuleName
+    , hsOutputDir       :: FilePath
+    , outputDirPolicy   :: OutputDirPolicy
+    , outputBindingSpec :: Maybe FilePath
     -- NOTE: Inputs (arguments) must be last, options must go before it.
-    , inputs          :: [UncheckedHashIncludeArg]
+    , inputs            :: [UncheckedHashIncludeArg]
     }
   deriving (Generic)
 
@@ -57,6 +58,7 @@ parseOpts =
       <*> parseHsModuleName
       <*> parseHsOutputDir
       <*> parseOutputDirPolicy
+      <*> optional parseGenBindingSpec
       <*> parseInputs
 
 {-------------------------------------------------------------------------------
@@ -85,7 +87,7 @@ exec GlobalOpts{..} Opts{..} = do
     artefacts :: Artefact ()
     artefacts = do
         writeBindingsMultiple hsOutputDir
-        forM_ config.outputBindingSpec writeBindingSpec
+        forM_ outputBindingSpec writeBindingSpec
 
 {-------------------------------------------------------------------------------
   Exception

hs-bindgen/fixtures/simple-binding-spec.yaml

@@ -47,9 +47,6 @@ data Config_ path = Config {
 
     -- * Backend
   , haddockPathStyle :: PathStyle
-
-    -- * Binding specifications
-  , outputBindingSpec :: Maybe path
   }
   deriving stock (Show, Eq, Generic)
   deriving stock (Functor, Foldable, Traversable)

hs-bindgen/src-internal/HsBindgen/Config.hs

@@ -97,9 +97,6 @@ withHsBindgen config ConfigTH{..} hashIncludes = do
         artefact = do
           deps  <- Dependencies
           decls <- FinalDecls
-          case config.outputBindingSpec of
-            Nothing  -> pure ()
-            Just rfp -> writeBindingSpec (toFilePath packageRoot rfp)
           pure (deps, mergeDecls safety decls)
 
     (deps, decls) <- liftIO $

hs-bindgen/src-internal/HsBindgen/TH/Internal.hs

@@ -11,7 +11,7 @@
 
 module Test.TH.Simple where
 
-import Optics ((%), (&), (.~), (?~))
+import Optics ((%), (&), (.~))
 
 import HsBindgen.Runtime.Prelude qualified
 
@@ -22,7 +22,6 @@ let cfg :: Config
             & #clang % #extraIncludeDirs .~ [
                   Pkg "examples"
                 ]
-            & #outputBindingSpec ?~ Pkg "fixtures/simple-binding-spec.yaml"
     cfgTH :: ConfigTH
     cfgTH = def
               & #verbosity .~ Verbosity Warning