-
Notifications
You must be signed in to change notification settings - Fork 5
Update compile-fixtures script to generate haddocks #1243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bolt12
wants to merge
12
commits into
main
Choose a base branch
from
bolt12/1159
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
hmm not sure if this needs to be merge in order for |
976ace8 to
3a81c60
Compare
Collaborator
Author
|
I have changed the comprehensive-ci.yml workflow to trigger on push so that I can see it works, then I will change to to |
ca90498 to
8ccc320
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the compile fixtures script to build the fixtures and haddocks at the same time using
haddock. The script now also generates a single index.html file where one can see the haddocks of each individual fixture.This PR also adds a new CI job that can be manually triggered, this CI job will essentially run some more comprehensive checks on top of the current ones, i.e. it will:
cabal checkfor all packagescabal sdistand try to see if it is buildable for all packagesThis PR closes #1159
Some nice features that would be nice to have: compile and generate haddocks for TH fixtures.