Add exercise contribution tests with proper mocks

Author: Branislav Nohaj

test/exercises/contribute_exercise_test.dart

@@ -93,6 +93,7 @@ void main() {
   /// Note: All 6 steps are rendered immediately by the Stepper widget,
   /// so all their required properties must be mocked.
   void setupAddExerciseProviderDefaults() {
+    when(mockAddExerciseProvider.author).thenReturn('');
     when(mockAddExerciseProvider.equipment).thenReturn([]);
     when(mockAddExerciseProvider.primaryMuscles).thenReturn([]);
     when(mockAddExerciseProvider.secondaryMuscles).thenReturn([]);
@@ -135,8 +136,8 @@ void main() {
 
   group('Form Field Validation Tests', () {
     testWidgets('Exercise name field is required and displays validation error', (
-      WidgetTester tester,
-    ) async {
+        WidgetTester tester,
+        ) async {
       // Setup: Create verified user with required data
       setupFullVerifiedUserContext();
 
@@ -186,8 +187,8 @@ void main() {
     });
 
     testWidgets('Alternative names field accepts multiple lines of text', (
-      WidgetTester tester,
-    ) async {
+        WidgetTester tester,
+        ) async {
       // Setup: Create verified user
       setupFullVerifiedUserContext();
 
@@ -405,7 +406,7 @@ void main() {
     testWidgets('Successful submission shows success dialog', (WidgetTester tester) async {
       // Setup: Create verified user and mock successful submission
       setupFullVerifiedUserContext();
-      when(mockAddExerciseProvider.addExercise()).thenAnswer((_) async => 1);
+      when(mockAddExerciseProvider.postExerciseToServer()).thenAnswer((_) async => 1);
       when(mockAddExerciseProvider.addImages(any)).thenAnswer((_) async => {});
       when(mockExerciseProvider.fetchAndSetExercise(any)).thenAnswer((_) async => testBenchPress);
       when(mockAddExerciseProvider.clear()).thenReturn(null);
@@ -425,7 +426,7 @@ void main() {
       final httpException = WgerHttpException({
         'name': ['This field is required'],
       });
-      when(mockAddExerciseProvider.addExercise()).thenThrow(httpException);
+      when(mockAddExerciseProvider.postExerciseToServer()).thenThrow(httpException);
 
       // Build the exercise contribution screen
       await tester.pumpWidget(createExerciseScreen());
@@ -437,11 +438,11 @@ void main() {
     });
 
     testWidgets('Provider clear method is called after successful submission', (
-      WidgetTester tester,
-    ) async {
+        WidgetTester tester,
+        ) async {
       // Setup: Mock successful submission flow
       setupFullVerifiedUserContext();
-      when(mockAddExerciseProvider.addExercise()).thenAnswer((_) async => 1);
+      when(mockAddExerciseProvider.postExerciseToServer()).thenAnswer((_) async => 1);
       when(mockAddExerciseProvider.addImages(any)).thenAnswer((_) async => {});
       when(mockExerciseProvider.fetchAndSetExercise(any)).thenAnswer((_) async => testBenchPress);
       when(mockAddExerciseProvider.clear()).thenReturn(null);
@@ -517,4 +518,4 @@ void main() {
       expect(profileButton, findsOneWidget);
     });
   });
-}
+}

test/exercises/contribute_exercise_test.mocks.dart

@@ -4,18 +4,18 @@
 
 // ignore_for_file: no_leading_underscores_for_library_prefixes
 import 'dart:async' as _i15;
-import 'dart:io' as _i12;
 import 'dart:ui' as _i16;
 
 import 'package:flutter/material.dart' as _i18;
 import 'package:mockito/mockito.dart' as _i1;
-import 'package:mockito/src/dummies.dart' as _i14;
+import 'package:mockito/src/dummies.dart' as _i13;
 import 'package:shared_preferences/shared_preferences.dart' as _i4;
 import 'package:wger/database/exercises/exercise_database.dart' as _i5;
 import 'package:wger/models/exercises/category.dart' as _i7;
 import 'package:wger/models/exercises/equipment.dart' as _i8;
 import 'package:wger/models/exercises/exercise.dart' as _i6;
-import 'package:wger/models/exercises/exercise_submission.dart' as _i13;
+import 'package:wger/models/exercises/exercise_submission.dart' as _i14;
+import 'package:wger/models/exercises/exercise_submission_images.dart' as _i12;
 import 'package:wger/models/exercises/language.dart' as _i10;
 import 'package:wger/models/exercises/muscle.dart' as _i9;
 import 'package:wger/models/exercises/variation.dart' as _i3;
@@ -110,12 +110,23 @@ class MockAddExerciseProvider extends _i1.Mock
           as _i2.WgerBaseProvider);
 
   @override
-  List<_i12.File> get exerciseImages =>
+  List<_i12.ExerciseSubmissionImage> get exerciseImages =>
       (super.noSuchMethod(
             Invocation.getter(#exerciseImages),
-            returnValue: <_i12.File>[],
+            returnValue: <_i12.ExerciseSubmissionImage>[],
           )
-          as List<_i12.File>);
+          as List<_i12.ExerciseSubmissionImage>);
+
+  @override
+  String get author =>
+      (super.noSuchMethod(
+            Invocation.getter(#author),
+            returnValue: _i13.dummyValue<String>(
+              this,
+              Invocation.getter(#author),
+            ),
+          )
+          as String);
 
   @override
   List<String> get alternateNamesEn =>
@@ -171,15 +182,21 @@ class MockAddExerciseProvider extends _i1.Mock
           as List<_i9.Muscle>);
 
   @override
-  _i13.ExerciseSubmissionApi get exerciseApiObject =>
+  _i14.ExerciseSubmissionApi get exerciseApiObject =>
       (super.noSuchMethod(
             Invocation.getter(#exerciseApiObject),
-            returnValue: _i14.dummyValue<_i13.ExerciseSubmissionApi>(
+            returnValue: _i13.dummyValue<_i14.ExerciseSubmissionApi>(
               this,
               Invocation.getter(#exerciseApiObject),
             ),
           )
-          as _i13.ExerciseSubmissionApi);
+          as _i14.ExerciseSubmissionApi);
+
+  @override
+  set author(String? value) => super.noSuchMethod(
+    Invocation.setter(#author, value),
+    returnValueForMissingStub: null,
+  );
 
   @override
   set exerciseNameEn(String? value) => super.noSuchMethod(
@@ -277,40 +294,22 @@ class MockAddExerciseProvider extends _i1.Mock
   );
 
   @override
-  void addExerciseImages(
-    List<_i12.File>? images, {
-    String? title,
-    String? author,
-    String? authorUrl,
-    String? sourceUrl,
-    String? derivativeSourceUrl,
-    String? style = '1',
-  }) => super.noSuchMethod(
-    Invocation.method(
-      #addExerciseImages,
-      [images],
-      {
-        #title: title,
-        #author: author,
-        #authorUrl: authorUrl,
-        #sourceUrl: sourceUrl,
-        #derivativeSourceUrl: derivativeSourceUrl,
-        #style: style,
-      },
-    ),
-    returnValueForMissingStub: null,
-  );
+  void addExerciseImages(List<_i12.ExerciseSubmissionImage>? images) =>
+      super.noSuchMethod(
+        Invocation.method(#addExerciseImages, [images]),
+        returnValueForMissingStub: null,
+      );
 
   @override
-  void removeExercise(String? path) => super.noSuchMethod(
-    Invocation.method(#removeExercise, [path]),
+  void removeImage(String? path) => super.noSuchMethod(
+    Invocation.method(#removeImage, [path]),
     returnValueForMissingStub: null,
   );
 
   @override
-  _i15.Future<int> addExercise() =>
+  _i15.Future<int> postExerciseToServer() =>
       (super.noSuchMethod(
-            Invocation.method(#addExercise, []),
+            Invocation.method(#postExerciseToServer, []),
             returnValue: _i15.Future<int>.value(0),
           )
           as _i15.Future<int>);