Flexible routines #1827
Merged
Flexible routines #1827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just a first version, will probably need to work a bit more on it
While this is not 100% correct, it is a clearer name
This can be used for example to label the different date ranges or weeks, or set other info such as "deload", etc.
This has only the information the client needs to render the workout day
This field is now a charfield so that new options can be added
This allows us to know which entries were part of a dropset or similar
It makes no sense to require this if the weight and repetitions values themselves are optional
Logs aren't used to compute the structure
This is mentioned in the docs and is not as important nowadays anyway
Otherwise, reloading would cause a 404
This is consistent with the other endpoints
This adds a minimum required server version, similar to the one used for the mobile app. This allows to better handle API changes. We also now use the packaging package to parse and compare versions, instead of using our own code.
# Conflicts: # wger/exercises/tests/test_exercise.py # wger/exercises/tests/test_exercise_translation.py # wger/nutrition/management/commands/sync-ingredients.py # wger/settings_global.py
This was clogging the console anyway
# Conflicts: # wger/weight/tests/test_entry.py # wger/weight/views.py
Using GUNICORN_CMD_ARGS is more flexible since it allows us to pass any other configuration option as needed and is a regular gunicorn env variable
# Conflicts: # requirements.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backend changes for the flexible routines
wger-project/react#975
wger-project/flutter#682