Skip to content

Commit 09db56b

Browse files
committed
Reorder promise resolutions for navigation API
The API method tracker finished promise vs. the navigation transition finished promise ordering did not match the tests and Chromium implementation. There's no real argument for one order vs. the other, so update the spec to match. Closes #10646.
1 parent b8ea975 commit 09db56b

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

source

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -95198,6 +95198,9 @@ interface <dfn interface>NavigationDestination</dfn> {
9519895198
<li><p><span data-x="concept-event-fire">Fire an event</span> named <code
9519995199
data-x="event-navigatesuccess">navigatesuccess</code> at <var>navigation</var>.</p></li>
9520095200

95201+
<li><p>If <var>apiMethodTracker</var> is non-null, then <span>resolve the finished
95202+
promise</span> for <var>apiMethodTracker</var>.</p></li>
95203+
9520195204
<li><p>If <var>navigation</var>'s <span
9520295205
data-x="concept-Navigation-transition">transition</span> is not null, then resolve
9520395206
<var>navigation</var>'s <span data-x="concept-Navigation-transition">transition</span>'s
@@ -95206,9 +95209,6 @@ interface <dfn interface>NavigationDestination</dfn> {
9520695209

9520795210
<li><p>Set <var>navigation</var>'s <span
9520895211
data-x="concept-Navigation-transition">transition</span> to null.</p></li>
95209-
95210-
<li><p>If <var>apiMethodTracker</var> is non-null, then <span>resolve the finished
95211-
promise</span> for <var>apiMethodTracker</var>.</p></li>
9521295212
</ol>
9521395213

9521495214
<p>and the following failure steps given reason <var>rejectionReason</var>:</p>
@@ -95238,6 +95238,9 @@ interface <dfn interface>NavigationDestination</dfn> {
9523895238
<code>ErrorEvent</code>, with additional attributes initialized according to
9523995239
<var>errorInfo</var>.</p></li>
9524095240

95241+
<li><p>If <var>apiMethodTracker</var> is non-null, then <span>reject the finished
95242+
promise</span> for <var>apiMethodTracker</var> with <var>rejectionReason</var>.</p></li>
95243+
9524195244
<li><p>If <var>navigation</var>'s <span
9524295245
data-x="concept-Navigation-transition">transition</span> is not null, then reject
9524395246
<var>navigation</var>'s <span data-x="concept-Navigation-transition">transition</span>'s
@@ -95246,9 +95249,6 @@ interface <dfn interface>NavigationDestination</dfn> {
9524695249

9524795250
<li><p>Set <var>navigation</var>'s <span
9524895251
data-x="concept-Navigation-transition">transition</span> to null.</p></li>
95249-
95250-
<li><p>If <var>apiMethodTracker</var> is non-null, then <span>reject the finished
95251-
promise</span> for <var>apiMethodTracker</var> with <var>rejectionReason</var>.</p></li>
9525295252
</ol>
9525395253
</li>
9525495254
</ol>

0 commit comments

Comments
 (0)