Skip to content

Commit 1d975e7

Browse files
Fixes left out of #1589 (#1593)
## Description Test and transaction updates to get integration tests passing again. - [ ] I have reviewed the [Guidelines for Contributing](CONTRIBUTING.md) and the [Code of Conduct](CODE_OF_CONDUCT.md).
1 parent f123399 commit 1d975e7

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

python/tests/api/writer/test_whylabs_integration.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,8 @@ def _get_org() -> str:
7171
@httpretty.activate(allow_net_connect=False, verbose=True)
7272
def test_whylabs_writer_throttle_retry():
7373
ENDPOINT = os.environ["WHYLABS_API_ENDPOINT"]
74-
ORG_ID = _get_org()
7574
MODEL_ID = "XXX"
76-
uri = f"{ENDPOINT}/v0/organizations/{ORG_ID}/log/async/{MODEL_ID}"
75+
uri = f"{ENDPOINT}/v1/log/async"
7776
httpretty.register_uri(httpretty.POST, uri, status=429) # Fake WhyLabs that throttles
7877
why.init(reinit=True, force_local=True)
7978
data = {"col1": 1, "col2": "foo"}
@@ -271,9 +270,8 @@ def test_put_column_schema_retry():
271270
@httpretty.activate(allow_net_connect=False, verbose=True)
272271
def test_log_async_retry():
273272
ENDPOINT = os.environ["WHYLABS_API_ENDPOINT"]
274-
ORG_ID = _get_org()
275273
MODEL_ID = "xxx"
276-
uri = f"{ENDPOINT}/v0/organizations/{ORG_ID}/log/async/{MODEL_ID}"
274+
uri = f"{ENDPOINT}/v1/log/async"
277275
httpretty.register_uri(httpretty.POST, uri, status=429) # Fake WhyLabs that throttles
278276

279277
writer = WhyLabsWriter(dataset_id=MODEL_ID)
@@ -651,8 +649,9 @@ def test_transaction_aborted():
651649
transaction_id = writer.start_transaction()
652650
status, id = writer.write(result)
653651
assert status
654-
writer._whylabs_client.abort_transaction(transaction_id)
652+
writer.abort_transaction()
655653
status, id = writer.write(result)
654+
assert transaction_id == writer._whylabs_client._transaction_id
656655
with pytest.raises(TransactionAbortedException) as e:
657656
writer.commit_transaction()
658657
assert str(e) == "Transaction has been aborted"

python/whylogs/api/writer/whylabs_transaction_writer.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ def __init__(
6767
transaction_id: Optional[str] = None,
6868
):
6969
super().__init__(org_id, api_key, dataset_id, api_client, ssl_ca_cert, _timeout_seconds, whylabs_client)
70-
transaction_id = transaction_id or self._whylabs_client.get_transaction_id() # type: ignore
70+
transaction_id = transaction_id or self._whylabs_client._transaction_id or self._whylabs_client.get_transaction_id() # type: ignore
7171
self._whylabs_client._transaction_id = transaction_id # type: ignore
7272
self._aborted: bool = False
7373

0 commit comments

Comments
 (0)