Skip to content

Fixing yellow warning for UIManager in ReactNative #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fixing yellow warning for UIManager in ReactNative #281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0c85edc
Updating access to UIManager with new API getViewManagerConfig.
BrunoCicciarello-TomTom Feb 4, 2019
467c521
Fixing podspec problem with npm install.
BrunoCicciarello-TomTom Feb 4, 2019
4dbbd92
Merge pull request #1 from wix/master
alimek Jun 6, 2019
f89e765
add constant for native component name
alimek Jun 6, 2019
2fe394b
Merge pull request #2 from wix/master
alimek Jun 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .npmignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,6 @@ fabric.properties
#
# gitignore contributors: remember to update Global/Xcode.gitignore, Objective-C.gitignore & Swift.gitignore

#Cocoapods
*.podspec

## Build generated
ios/build/
ios/DerivedData/
Expand Down
11 changes: 6 additions & 5 deletions lib/src/InteractableView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
import React, { Component } from 'react';
import ReactNative, { requireNativeComponent, Animated, NativeModules, UIManager, Platform } from 'react-native';

const NATIVE_COMPONENT_NAME = 'InteractableView';
// this is required in order to perform imperative commands
const NativeViewManager = NativeModules.InteractableViewManager;

const NativeInteractableView = requireNativeComponent('InteractableView', null);
const NativeInteractableView = requireNativeComponent(NATIVE_COMPONENT_NAME, null);

class WrappedInteractableView extends Component {
render() {
Expand Down Expand Up @@ -73,7 +74,7 @@ class WrappedAnimatedInteractableView extends Component {
} else if (Platform.OS === 'android') {
UIManager.dispatchViewManagerCommand(
ReactNative.findNodeHandle(this),
UIManager.InteractableView.Commands.setVelocity,
UIManager.getViewManagerConfig(NATIVE_COMPONENT_NAME).Commands.setVelocity,
[params],
);
}
Expand All @@ -85,7 +86,7 @@ class WrappedAnimatedInteractableView extends Component {
} else if (Platform.OS === 'android') {
UIManager.dispatchViewManagerCommand(
ReactNative.findNodeHandle(this),
UIManager.InteractableView.Commands.snapTo,
UIManager.getViewManagerConfig(NATIVE_COMPONENT_NAME).Commands.snapTo,
[params],
);
}
Expand All @@ -97,7 +98,7 @@ class WrappedAnimatedInteractableView extends Component {
} else if (Platform.OS === 'android') {
UIManager.dispatchViewManagerCommand(
ReactNative.findNodeHandle(this),
UIManager.InteractableView.Commands.changePosition,
UIManager.getViewManagerConfig(NATIVE_COMPONENT_NAME).Commands.changePosition,
[params],
);
}
Expand All @@ -107,7 +108,7 @@ class WrappedAnimatedInteractableView extends Component {
if (Platform.OS === 'android') {
UIManager.dispatchViewManagerCommand(
ReactNative.findNodeHandle(this),
UIManager.InteractableView.Commands.bringToFront,
UIManager.getViewManagerConfig(NATIVE_COMPONENT_NAME).Commands.bringToFront,
[],
);
}
Expand Down