Fix random TS errors (#2314)

* Fix random TS errors

* Update src/components/picker/PickerPresenter.ts

Co-authored-by: Miki Leib <[email protected]>

* Update src/components/picker/types.tsx

Co-authored-by: Miki Leib <[email protected]>

Co-authored-by: Miki Leib <[email protected]>

Author: ethanshar

src/components/image/index.tsx

@@ -147,7 +147,7 @@ class Image extends PureComponent<Props, State> {
     if (Constants.isAndroid) {
       const {source} = this.props;
       const url = _.get(source, 'uri');
-      const isGif = /(http(s?):)([/|.|\w|\s|-])*\.gif/.test(url);
+      const isGif = /(http(s?):)([/|.|\w|\s|-])*\.gif/.test(url ?? '');
       return isGif;
     }
   }

src/components/picker/PickerItem.tsx

@@ -11,7 +11,7 @@ import Image from '../image';
 import Text from '../text';
 import {getItemLabel, isItemSelected} from './PickerPresenter';
 import PickerContext from './PickerContext';
-import {PickerItemProps} from './types';
+import {PickerItemProps, PickerSingleValue} from './types';
 
 /**
  * @description: Picker.Item, for configuring the Picker's selectable options
@@ -64,7 +64,7 @@ const PickerItem = (props: PickerItemProps) => {
     if (migrate) {
       context.onPress(value);
     } else {
-      context.onPress(typeof value === 'object' || context.isMultiMode ? value : {value, label: itemLabel});
+      context.onPress(typeof value === 'object' || context.isMultiMode ? value : ({value, label: itemLabel}) as PickerSingleValue);
     }
   }, [migrate, value, context.onPress]);
 

src/components/picker/PickerPresenter.ts

@@ -45,6 +45,6 @@ export function getItemLabel(label: string, value: PickerValue, getItemLabel: Pi
   return label;
 }
 
-export function shouldFilterOut(searchValue: string, itemLabel: string) {
+export function shouldFilterOut(searchValue: string, itemLabel?: string) {
   return !_.includes(_.lowerCase(itemLabel), _.lowerCase(searchValue));
 }

src/components/picker/types.tsx

@@ -94,7 +94,7 @@ export type PickerBaseProps = Omit<TextFieldProps, 'value' | 'onChange'> &
     renderItem?: (
       value: PickerValue,
       itemProps: PickerItemProps & {isSelected: boolean; isItemDisabled: boolean},
-      label: string
+      label?: string
     ) => React.ReactElement;
     /**
      * Render custom picker modal (e.g ({visible, children, toggleModal}) => {...})