Skip to content

Commit 2ff7955

Browse files
author
swaroopakkineni
committed
Simplify auto-idempotency to always generate keys
- Remove auto_idempotency_keys config flag - Always auto-generate idempotency keys when not provided - Remove related test for disabled flag
1 parent ec4f231 commit 2ff7955

File tree

3 files changed

+3
-31
lines changed

3 files changed

+3
-31
lines changed

lib/workos/audit_logs.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ class << self
1919
#
2020
# @return [nil]
2121
def create_event(organization:, event:, idempotency_key: nil)
22-
# Auto-generate idempotency key if not provided and enabled
23-
if idempotency_key.nil? && WorkOS.config.auto_idempotency_keys
22+
# Auto-generate idempotency key if not provided
23+
if idempotency_key.nil?
2424
idempotency_key = SecureRandom.uuid
2525
end
2626

lib/workos/configuration.rb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,11 @@
33
module WorkOS
44
# Configuration class sets config initializer
55
class Configuration
6-
attr_accessor :api_hostname, :timeout, :key, :max_retries, :auto_idempotency_keys
6+
attr_accessor :api_hostname, :timeout, :key, :max_retries
77

88
def initialize
99
@timeout = 60
1010
@max_retries = 3
11-
@auto_idempotency_keys = true
1211
end
1312

1413
def key!

spec/lib/workos/audit_logs_spec.rb

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -86,33 +86,6 @@
8686
end
8787
end
8888

89-
context 'with auto_idempotency_keys disabled' do
90-
before do
91-
WorkOS.config.auto_idempotency_keys = false
92-
end
93-
94-
after do
95-
WorkOS.config.auto_idempotency_keys = true
96-
end
97-
98-
it 'does not generate idempotency key' do
99-
request = double('request')
100-
expect(described_class).to receive(:post_request).with(
101-
path: '/audit_logs/events',
102-
auth: true,
103-
idempotency_key: nil,
104-
body: hash_including(organization_id: 'org_123'),
105-
).and_return(request)
106-
107-
allow(described_class).to receive(:execute_request).and_return(double(code: '201'))
108-
109-
described_class.create_event(
110-
organization: 'org_123',
111-
event: valid_event,
112-
)
113-
end
114-
end
115-
11689
context 'with invalid event' do
11790
it 'returns error' do
11891
VCR.use_cassette 'audit_logs/create_event_invalid', match_requests_on: %i[path body] do

0 commit comments

Comments
 (0)