Skip to content

Commit 39f9ac0

Browse files
authored
Minor CSS fix ups (#812)
1 parent 11aa244 commit 39f9ac0

File tree

4 files changed

+24
-36
lines changed

4 files changed

+24
-36
lines changed

vscode-wpilib/resources/media/icons.css

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,3 +91,11 @@
9191
.codicon-chrome-minimize:before {
9292
content: '\eaba';
9393
}
94+
95+
.codicon-notebook:before {
96+
content: '\ebaf';
97+
}
98+
99+
.codicon-notebook-template:before {
100+
content: '\ebbf';
101+
}

vscode-wpilib/resources/media/main.css

Lines changed: 4 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,6 @@
77
}
88
}
99

10-
.uninstall-button .vscode-select select {
11-
height: 24px;
12-
box-sizing: border-box;
13-
line-height: 18px;
14-
padding: 2px 4px;
15-
border-radius: 2px;
16-
}
17-
1810
.uninstall-button button[id*='version-action'],
1911
.uninstall-button button[id*='uninstall-action'],
2012
.uninstall-button button[id*='install-action'] {
@@ -166,17 +158,6 @@ button[id*='version-action'] {
166158
width: 100%;
167159
}
168160

169-
.project-select {
170-
min-width: 250px;
171-
background-color: var(--vscode-dropdown-background);
172-
border: 1px solid var(--vscode-dropdown-border);
173-
color: var(--vscode-dropdown-foreground);
174-
padding: 6px 8px;
175-
border-radius: 4px;
176-
cursor: pointer;
177-
width: 100%;
178-
}
179-
180161
.project-actions {
181162
display: flex;
182163
justify-content: flex-end;
@@ -344,6 +325,10 @@ button[id*='version-action'] {
344325
color: var(--vscode-descriptionForeground);
345326
}
346327

328+
.card-icon i.codicon {
329+
font-size: 48px;
330+
}
331+
347332
.selection-card.selected .card-icon {
348333
color: var(--vscode-button-background);
349334
}

vscode-wpilib/resources/webviews/projectcreator.html

Lines changed: 8 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -32,24 +32,14 @@ <h2>Step 1: Select Project Type</h2>
3232
<h3>Template</h3>
3333
<p>Start with a basic robot program structure</p>
3434
<div class="card-icon">
35-
<svg viewBox="0 0 24 24" width="48" height="48">
36-
<path
37-
fill="currentColor"
38-
d="M14,17H7V15H14M17,13H7V11H17M17,9H7V7H17M19,3H5C3.89,3 3,3.89 3,5V19A2,2 0 0,0 5,21H19A2,2 0 0,0 21,19V5C21,3.89 20.1,3 19,3Z"
39-
/>
40-
</svg>
35+
<i class="codicon codicon-notebook-template"></i>
4136
</div>
4237
</div>
4338
<div class="selection-card" data-value="Example">
4439
<h3>Example</h3>
4540
<p>Start with a complete example project</p>
4641
<div class="card-icon">
47-
<svg viewBox="0 0 24 24" width="48" height="48">
48-
<path
49-
fill="currentColor"
50-
d="M8,16H16V18H8V16M8,12H16V14H8V12M14,2H6A2,2 0 0,0 4,4V20A2,2 0 0,0 6,22H18A2,2 0 0,0 20,20V8L14,2M18,20H6V4H13V9H18V20Z"
51-
/>
52-
</svg>
42+
<i class="codicon codicon-notebook"></i>
5343
</div>
5444
</div>
5545
</div>
@@ -70,17 +60,19 @@ <h2>Step 2: Select Language & Base</h2>
7060

7161
<div class="project-row">
7262
<div class="project-label"><b>Language</b></div>
73-
<div class="select-wrapper">
74-
<select id="language-select" class="project-select" disabled>
63+
<div class="select-wrapper vscode-select">
64+
<i class="codicon codicon-chevron-right chevron-icon"></i>
65+
<select id="language-select" disabled>
7566
<option value="" selected disabled>Select a language</option>
7667
</select>
7768
</div>
7869
</div>
7970

8071
<div class="project-row">
8172
<div class="project-label"><b>Project Base</b></div>
82-
<div class="select-wrapper">
83-
<select id="base-select" class="project-select" disabled>
73+
<div class="select-wrapper vscode-select">
74+
<i class="codicon codicon-chevron-right chevron-icon"></i>
75+
<select id="base-select" disabled>
8476
<option value="" selected disabled>Select a project base</option>
8577
</select>
8678
</div>

vscode-wpilib/src/webviews/webviewbase.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,10 @@ export abstract class WebViewBase {
3939

4040
this.html = this.html.replace(
4141
'</head>',
42-
`<link rel="stylesheet" href="replaceresource/resources/media/icons.css" />\r\n<link rel="stylesheet" href="replaceresource/resources/media/vscode-elements.css" />\r\n<link rel="stylesheet" href="replaceresource/resources/media/main.css" />\r\n</head>`
42+
`<link rel="stylesheet" href="replaceresource/resources/media/icons.css" />
43+
<link rel="stylesheet" href="replaceresource/resources/media/vscode-elements.css" />
44+
<link rel="stylesheet" href="replaceresource/resources/media/main.css" /></head>
45+
`
4346
);
4447

4548
if (localeDomains) {

0 commit comments

Comments
 (0)