Skip to content

Commit 5730f70

Browse files
authored
Remove unnecessary setting change commands (#792)
1 parent bf812db commit 5730f70

File tree

7 files changed

+8
-491
lines changed

7 files changed

+8
-491
lines changed

vscode-wpilib/locale/zh-cn/message.yaml

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -18,31 +18,18 @@ No dependencies installed: 没有安装任何依赖
1818
# Check offline or online?
1919
# Cannot deploy code in an empty workspace
2020
# Cannot debug code in an empty workspace
21-
# Cannot simulate number in an empty workspace
21+
# Cannot simulate code in an empty workspace
2222
# Cannot start tests in an empty workspace
2323
# Cannot create command in an empty workspace
2424
# Cannot set team number in an empty workspace
2525
# Cannot set language in an empty workspace
26-
# Cannot set skip tests in an empty workspace
27-
# Cannot set offline in an empty workspace
28-
# Cannot set deploy offline in an empty workspace
29-
# Cannot set stop simulation in an empty workspace
30-
# Cannot set auto save in an empty workspace
31-
# Cannot set team number in an empty workspace
3226
# Cannot run command on empty workspace
3327
# Cannot reset auto update with an empty workspace
3428
# Cannot install gradle tools with an empty workspace
3529
# Cannot change desktop with an empty workspace
3630
# Cannot create into non empty folder
3731
# Must select a folder to create a command
3832
# No languages available to set
39-
# Skip tests on deploy? Currently {0}
40-
# Run commands other then deploy in offline mode? Currently {0}
41-
# Run deploy command in offline mode? Currently {0}
42-
# Stop simulation debugging on entry? Currently {0}
43-
Automatically save on deploy? Currently {0}: 部署时自动保存吗?当前为 {0}
44-
# Cannot set start RioLog in an empty workspace
45-
# Automatically start RioLog on deploy? Currently {0}
4633
# Successfully set java.home
4734
# Enable Desktop Support for Project? Currently ${isEnabled}
4835
# Invalid project format to add or remove desktop support.

vscode-wpilib/locale/zh-cn/package.i18n.yaml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,6 @@ wpilibcore.debugCode.title: 调试机器人代码
88
wpilibcore.simulateCode.title: 在电脑上模拟运行机器人代码
99
wpilibcore.simulateHwCode.title: Hardware Sim Robot Code
1010
wpilibcore.setLanguage.title: 设置语言
11-
wpilibcore.setAutoSave.title: 设置部署时自动保存
12-
wpilibcore.setSkipTests.title: 设置是否跳过测试API
13-
wpilibcore.setSkipSelectSimulateExtension.title: Change Skip Selection of Simulation Extensions Setting
14-
wpilibcore.setSelectDefaultSimulateExtension.title: Change Default Selection of Simulation Extensions Setting
15-
wpilibcore.setStopSimulationOnEntry.title: 设置是否在进入时停止模拟运行
16-
wpilibcore.setUseWinDbgX.title: Change Use WinDbg Preview (From Store) as Windows Debugger Setting
17-
wpilibcore.setStartRioLog.title: 设置是否在部署时启动 RioLog
1811
wpilibcore.createCommand.title: 创建一个新的类/命令
1912
wpilibcore.cancelTasks.title: 取消正在运行的任务
2013
wpilibcore.help.title: 打开 WPILib 帮助
@@ -31,8 +24,6 @@ wpilibcore.showLogFolder.title: 显示目录文件夹
3124
wpilibcore.resetAutoUpdate.title: 重制自动检查 WPILib 更新设置
3225
wpilibcore.runGradleCommand.title: 在 Gradle 中执行命令
3326
wpilibcore.changeDesktop.title: 设置桌面支持属性
34-
wpilibcore.setDeployOffline.title: 在离线模式中 更改 部署/调试命令 设置
35-
wpilibcore.setOffline.title: 在离线模式中 更改 部署/调试命令 外的设置
3627
wpilibcore.selectCppBinaryTypes.title: 选择 C++ Intellisense Binary Types
3728
wpilibcore.openApiDocumentation.title: 打开 API 文档
3829
wpilibcore.getProjectInformation.title: 显示项目信息

vscode-wpilib/package.json

Lines changed: 7 additions & 76 deletions
Original file line numberDiff line numberDiff line change
@@ -26,15 +26,6 @@
2626
"onCommand:wpilibcore.simulateCode",
2727
"onCommand:wpilibcore.simulateHwCode",
2828
"onCommand:wpilibcore.setLanguage",
29-
"onCommand:wpilibcore.setAutoSave",
30-
"onCommand:wpilibcore.setSkipTests",
31-
"onCommand:wpilibcore.setSelectDefaultSimulateExtension",
32-
"onCommand:wpilibcore.setSkipSelectSimulateExtension",
33-
"onCommand:wpilibcore.setOffline",
34-
"onCommand:wpilibcore.setStopSimulationOnEntry",
35-
"onCommand:wpilibcore.setUseWinDbgX",
36-
"onCommand:wpilibcore.setStartRioLog",
37-
"onCommand:wpilibcore.setDeployOffline",
3829
"onCommand:wpilibcore.createCommand",
3930
"onCommand:wpilibcore.cancelTasks",
4031
"onCommand:wpilibcore.help",
@@ -113,7 +104,7 @@
113104
"wpilib.additionalGradleArguments": {
114105
"type": "string",
115106
"default": "",
116-
"description": "For debugging only, passes extra arguments to gradle invocations",
107+
"description": "For debugging only, passes extra arguments to Gradle invocations",
117108
"scope": "resource"
118109
},
119110
"wpilib.autoSaveOnDeploy": {
@@ -137,43 +128,37 @@
137128
"wpilib.offline": {
138129
"type": "boolean",
139130
"default": false,
140-
"description": "Perform gradle commands other then deploy/debug with offline flag",
131+
"description": "Perform Gradle commands other then deploy/debug in offline mode (will not attempt to automatically pull missing dependencies from the Internet)",
141132
"scope": "resource"
142133
},
143134
"wpilib.deployOffline": {
144135
"type": "boolean",
145136
"default": true,
146-
"description": "Perform gradle deploy command with offline flag",
137+
"description": "Perform Gradle deploy command in offline mode (will not attempt to automatically pull missing dependencies from the Internet)",
147138
"scope": "resource"
148139
},
149140
"wpilib.skipTests": {
150141
"type": "boolean",
151142
"default": false,
152-
"description": "Set to skip running tests on build",
143+
"description": "Skip running tests on build",
153144
"scope": "resource"
154145
},
155146
"wpilib.skipSelectSimulateExtension": {
156147
"type": "boolean",
157148
"default": false,
158-
"description": "Set to skip selection of simulation extensions",
159-
"scope": "resource"
160-
},
161-
"wpilib.selectDefaultSimulateExtension": {
162-
"type": "boolean",
163-
"default": false,
164-
"description": "Set to select all simulation extensions by default",
149+
"description": "Skip selection of simulation extensions",
165150
"scope": "resource"
166151
},
167152
"wpilib.stopSimulationOnEntry": {
168153
"type": "boolean",
169154
"default": false,
170-
"description": "Set to make simulation code stop automatically on entry",
155+
"description": "Make simulation code stop automatically on entry",
171156
"scope": "resource"
172157
},
173158
"wpilib.useWindbgX": {
174159
"type": "boolean",
175160
"default": false,
176-
"description": "Use WinDbg Preview (from store) as C++ debugger (Windows only)",
161+
"description": "Use WinDbg Preview (from the Microsoft Store) as C++ debugger (Windows only)",
177162
"scope": "resource"
178163
}
179164
}
@@ -241,60 +226,6 @@
241226
"category": "WPILib",
242227
"enablement": "isWorkspaceTrusted"
243228
},
244-
{
245-
"command": "wpilibcore.setAutoSave",
246-
"title": "%wpilibcore.setAutoSave.title%",
247-
"category": "WPILib",
248-
"enablement": "isWorkspaceTrusted"
249-
},
250-
{
251-
"command": "wpilibcore.setSkipTests",
252-
"title": "%wpilibcore.setSkipTests.title%",
253-
"category": "WPILib",
254-
"enablement": "isWorkspaceTrusted"
255-
},
256-
{
257-
"command": "wpilibcore.setSelectDefaultSimulateExtension",
258-
"title": "%wpilibcore.setSelectDefaultSimulateExtension.title%",
259-
"category": "WPILib",
260-
"enablement": "isWorkspaceTrusted"
261-
},
262-
{
263-
"command": "wpilibcore.setSkipSelectSimulateExtension",
264-
"title": "%wpilibcore.setSkipSelectSimulateExtension.title%",
265-
"category": "WPILib",
266-
"enablement": "isWorkspaceTrusted"
267-
},
268-
{
269-
"command": "wpilibcore.setOffline",
270-
"title": "%wpilibcore.setOffline.title%",
271-
"category": "WPILib",
272-
"enablement": "isWorkspaceTrusted"
273-
},
274-
{
275-
"command": "wpilibcore.setStopSimulationOnEntry",
276-
"title": "%wpilibcore.setStopSimulationOnEntry.title%",
277-
"category": "WPILib",
278-
"enablement": "isWorkspaceTrusted"
279-
},
280-
{
281-
"command": "wpilibcore.setUseWinDbgX",
282-
"title": "%wpilibcore.setUseWinDbgX.title%",
283-
"category": "WPILib",
284-
"enablement": "isWorkspaceTrusted"
285-
},
286-
{
287-
"command": "wpilibcore.setStartRioLog",
288-
"title": "%wpilibcore.setStartRioLog.title%",
289-
"category": "WPILib",
290-
"enablement": "isWorkspaceTrusted"
291-
},
292-
{
293-
"command": "wpilibcore.setDeployOffline",
294-
"title": "%wpilibcore.setDeployOffline.title%",
295-
"category": "WPILib",
296-
"enablement": "isWorkspaceTrusted"
297-
},
298229
{
299230
"command": "wpilibcore.createCommand",
300231
"title": "%wpilibcore.createCommand.title%",

vscode-wpilib/package.nls.json

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,6 @@
99
"wpilibcore.simulateCode.title": "Simulate Robot Code",
1010
"wpilibcore.simulateHwCode.title": "Hardware Sim Robot Code",
1111
"wpilibcore.setLanguage.title": "Change Language Setting",
12-
"wpilibcore.setAutoSave.title": "Change Auto Save On Deploy Setting",
13-
"wpilibcore.setSkipTests.title": "Change Skip Tests On Deploy Setting",
14-
"wpilibcore.setSkipSelectSimulateExtension.title": "Change Skip Selection of Simulation Extensions Setting",
15-
"wpilibcore.setSelectDefaultSimulateExtension.title": "Change Default Selection of Simulation Extensions Setting",
16-
"wpilibcore.setOffline.title": "Change Run Commands Except Deploy/Debug in Offline Mode Setting",
17-
"wpilibcore.setDeployOffline.title": "Change Run Deploy/Debug Command in Offline Mode Setting",
18-
"wpilibcore.setStopSimulationOnEntry.title": "Change Stop Simulation on Entry Setting",
19-
"wpilibcore.setUseWinDbgX.title": "Change Use WinDbg Preview (From Store) as Windows Debugger Setting",
20-
"wpilibcore.setStartRioLog.title": "Change Auto Start RioLog on Deploy Setting",
2112
"wpilibcore.createCommand.title": "Create a new class/command",
2213
"wpilibcore.cancelTasks.title": "Cancel currently running tasks",
2314
"wpilibcore.help.title": "Open WPILib Help",

vscode-wpilib/src/api.ts

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -115,27 +115,18 @@ export interface IPreferences {
115115
getCurrentLanguage(): string;
116116
setCurrentLanguage(language: string): Promise<void>;
117117
getAutoStartRioLog(): boolean;
118-
setAutoStartRioLog(autoStart: boolean, global: boolean): Promise<void>;
119118
getAutoSaveOnDeploy(): boolean;
120-
setAutoSaveOnDeploy(autoSave: boolean, global: boolean): Promise<void>;
121119
getIsWPILibProject(): boolean;
122120
getEnableCppIntellisense(): boolean;
123121
setEnableCppIntellisense(set: boolean): Promise<void>;
124122
getProjectYear(): string;
125123
setProjectYear(year: string): Promise<void>;
126124
getSkipTests(): boolean;
127-
getSelectDefaultSimulateExtension(): boolean;
128125
getStopSimulationOnEntry(): boolean;
129126
getAdditionalGradleArguments(): string;
130-
setSkipTests(value: boolean, global: boolean): Promise<void>;
131-
setSelectDefaultSimulateExtension(value: boolean, global: boolean): Promise<void>;
132-
setStopSimulationOnEntry(value: boolean, global: boolean): Promise<void>;
133127
getOffline(): boolean;
134-
setOffline(value: boolean, global: boolean): Promise<void>;
135128
getDeployOffline(): boolean;
136-
setDeployOffline(value: boolean, global: boolean): Promise<void>;
137129
getSkipSelectSimulateExtension(): boolean;
138-
setSkipSelectSimulateExtension(value: boolean, global: boolean): Promise<void>;
139130
}
140131

141132
export interface IExampleTemplateCreator {

vscode-wpilib/src/preferences.ts

Lines changed: 0 additions & 72 deletions
Original file line numberDiff line numberDiff line change
@@ -140,54 +140,6 @@ export class Preferences implements IPreferences {
140140
return res;
141141
}
142142

143-
public async setAutoStartRioLog(autoStart: boolean, global: boolean): Promise<void> {
144-
let target: vscode.ConfigurationTarget = vscode.ConfigurationTarget.Global;
145-
if (!global) {
146-
target = vscode.ConfigurationTarget.WorkspaceFolder;
147-
}
148-
return this.getConfiguration().update('autoStartRioLog', autoStart, target);
149-
}
150-
151-
public async setOffline(value: boolean, global: boolean): Promise<void> {
152-
let target: vscode.ConfigurationTarget = vscode.ConfigurationTarget.Global;
153-
if (!global) {
154-
target = vscode.ConfigurationTarget.WorkspaceFolder;
155-
}
156-
return this.getConfiguration().update('offline', value, target);
157-
}
158-
159-
public async setStopSimulationOnEntry(value: boolean, global: boolean): Promise<void> {
160-
let target: vscode.ConfigurationTarget = vscode.ConfigurationTarget.Global;
161-
if (!global) {
162-
target = vscode.ConfigurationTarget.WorkspaceFolder;
163-
}
164-
return this.getConfiguration().update('stopSimulationOnEntry', value, target);
165-
}
166-
167-
public async setSkipTests(value: boolean, global: boolean): Promise<void> {
168-
let target: vscode.ConfigurationTarget = vscode.ConfigurationTarget.Global;
169-
if (!global) {
170-
target = vscode.ConfigurationTarget.WorkspaceFolder;
171-
}
172-
return this.getConfiguration().update('skipTests', value, target);
173-
}
174-
175-
public async setSkipSelectSimulateExtension(value: boolean, global: boolean): Promise<void> {
176-
let target: vscode.ConfigurationTarget = vscode.ConfigurationTarget.Global;
177-
if (!global) {
178-
target = vscode.ConfigurationTarget.WorkspaceFolder;
179-
}
180-
return this.getConfiguration().update('skipSelectSimulateExtension', value, target);
181-
}
182-
183-
public async setSelectDefaultSimulateExtension(value: boolean, global: boolean): Promise<void> {
184-
let target: vscode.ConfigurationTarget = vscode.ConfigurationTarget.Global;
185-
if (!global) {
186-
target = vscode.ConfigurationTarget.WorkspaceFolder;
187-
}
188-
return this.getConfiguration().update('selectDefaultSimulateExtension', value, target);
189-
}
190-
191143
public getAutoSaveOnDeploy(): boolean {
192144
const res = this.getConfiguration().get<boolean>('autoSaveOnDeploy');
193145
if (res === undefined) {
@@ -196,14 +148,6 @@ export class Preferences implements IPreferences {
196148
return res;
197149
}
198150

199-
public async setAutoSaveOnDeploy(autoSave: boolean, global: boolean): Promise<void> {
200-
let target: vscode.ConfigurationTarget = vscode.ConfigurationTarget.Global;
201-
if (!global) {
202-
target = vscode.ConfigurationTarget.WorkspaceFolder;
203-
}
204-
return this.getConfiguration().update('autoSaveOnDeploy', autoSave, target);
205-
}
206-
207151
public getAdditionalGradleArguments(): string {
208152
const res = this.getConfiguration().get<string>('additionalGradleArguments');
209153
if (res === undefined) {
@@ -236,14 +180,6 @@ export class Preferences implements IPreferences {
236180
return res;
237181
}
238182

239-
public getSelectDefaultSimulateExtension(): boolean {
240-
const res = this.getConfiguration().get<boolean>('selectDefaultSimulateExtension');
241-
if (res === undefined) {
242-
return false;
243-
}
244-
return res;
245-
}
246-
247183
public getStopSimulationOnEntry(): boolean {
248184
const res = this.getConfiguration().get<boolean>('stopSimulationOnEntry');
249185
if (res === undefined) {
@@ -252,14 +188,6 @@ export class Preferences implements IPreferences {
252188
return res;
253189
}
254190

255-
public async setDeployOffline(value: boolean, global: boolean): Promise<void> {
256-
let target: vscode.ConfigurationTarget = vscode.ConfigurationTarget.Global;
257-
if (!global) {
258-
target = vscode.ConfigurationTarget.WorkspaceFolder;
259-
}
260-
return this.getConfiguration().update('deployOffline', value, target);
261-
}
262-
263191
public getDeployOffline(): boolean {
264192
const res = this.getConfiguration().get<boolean>('deployOffline');
265193
if (res === undefined) {

0 commit comments

Comments
 (0)