Migrate flake8, isort, black rules to ruff (#49)

* Migrate flake8 rules to ruff

Translating the previous flake8 rules in setup.cfg to ruff rules in pyproject.toml. Did not keep any of the ignored rules since none of them were triggered. Dropped the deprecated flake8-mypy (T4) rule.

* Fix C419 unneccesary list-comprehension

* Add flake8-simplify rule

Xref https://docs.astral.sh/ruff/rules/#flake8-simplify-sim

* Remove black and black-jupyter pre-commit hooks

* Use ruff's built-in isort lint rule

Xref https://docs.astral.sh/ruff/rules/#isort-i

Author: weiji14

.pre-commit-config.yaml

@@ -27,26 +27,19 @@ repos:
         args:
           - "--py38-plus"
 
-  - repo: https://github.com/psf/black
-    rev: 24.3.0
-    hooks:
-      - id: black
-      - id: black-jupyter
-
   - repo: https://github.com/keewis/blackdoc
     rev: v0.3.9
     hooks:
       - id: blackdoc
 
-  - repo: https://github.com/PyCQA/flake8
-    rev: 7.0.0
-    hooks:
-      - id: flake8
-
-  - repo: https://github.com/PyCQA/isort
-    rev: 5.13.2
+  - repo: https://github.com/astral-sh/ruff-pre-commit
+    rev: v0.4.10
     hooks:
-      - id: isort
+      - id: ruff
+        types_or: [python, pyi, jupyter]
+        args: [--fix]
+      - id: ruff-format
+        types_or: [python, pyi, jupyter]
 
   - repo: https://github.com/pre-commit/mirrors-prettier
     rev: v4.0.0-alpha.8

cupy_xarray/accessors.py

@@ -127,7 +127,7 @@ def is_cupy(self):
         is_cupy: bool
             Whether the underlying data is a cupy array.
         """
-        return all([da.cupy.is_cupy for da in self.ds.data_vars.values()])
+        return all(da.cupy.is_cupy for da in self.ds.data_vars.values())
 
     def as_cupy(self):
         """

pyproject.toml

@@ -1,3 +1,19 @@
-[tool.black]
-line-length = 100
-target-version = ['py38']
+[tool.ruff]
+line-length = 100  # E501 (line-too-long)
+exclude = [
+    "docs",
+    "versioneer.py",
+    "cupy_xarray/_version.py",
+]
+
+[tool.ruff.lint]
+select = [
+    "B",    # flake8-bugbear
+    "C4",   # flake8-comprehensions
+    "C90",  # mccabe
+    "E",    # pycodestyle
+    "F",    # pyflakes
+    "I",    # isort
+    "SIM",  # flake8-simplify
+    "W",    # pycodestyle warnings
+]

setup.cfg

@@ -5,18 +5,3 @@ versionfile_source = cupy_xarray/_version.py
 versionfile_build = cupy_xarray/_version.py
 tag_prefix =
 parentdir_prefix =
-
-[flake8]
-exclude = docs,versioneer.py,cupy_xarray/_version.py
-ignore = E203,E266,E501,W503,E722,E402,C901,E731
-max-line-length = 100
-max-complexity = 18
-select = B,C,E,F,W,T4,B9
-
-[isort]
-profile=black
-skip=
-    docs/source/conf.py
-    setup.py
-    versioneer.py
-    cupy_xarray/_version.py