-
-
Notifications
You must be signed in to change notification settings - Fork 135
update function name in target: set_prefix → set_prefixdir #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@binLep is attempting to deploy a commit to the waruqi's projects Team on Vercel. A member of the Team first needs to authorize it. |
❌ Deploy Preview for mellow-creponne-9cce3d failed.
|
Summary of ChangesHello @binLep, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on a documentation update, specifically renaming the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly renames the function set_prefix to set_prefixdir in the documentation examples. The changes are accurate. I've added a couple of comments to suggest an improvement to the function's prototype documentation, which is currently incomplete and doesn't reflect all valid ways to call the function as shown in the examples.
|
|
||
| ```lua | ||
| set_prefix("prefixdir", {bindir = "mybin", libdir = "mylib", includedir = "myinc"}) | ||
| set_prefixdir("prefixdir", {bindir = "mybin", libdir = "mylib", includedir = "myinc"}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This example correctly uses set_prefixdir with two arguments. However, the function prototype documented for set_prefixdir on line 4826 only shows one argument (prefixdir: <string>). To avoid confusion and improve documentation quality, please consider updating the function prototype to include the optional second table argument, for example: set_prefixdir(prefixdir: <string>, options?: <table>).
|
|
||
| ```lua | ||
| set_prefix("prefixdir", {bindir = "mybin", libdir = "mylib", includedir = "myinc"}) | ||
| set_prefixdir("prefixdir", {bindir = "mybin", libdir = "mylib", includedir = "myinc"}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This example correctly uses set_prefixdir with two arguments. However, the function prototype documented for set_prefixdir on line 4910 only shows one argument (prefixdir: <string>). To avoid confusion and improve documentation quality, please consider updating the function prototype to include the optional second table argument, for example: set_prefixdir(prefixdir: <string>, options?: <table>).
as the title says