Skip to content

Commit c6f22d9

Browse files
committed
Fix "Increment on non-numeric string is deprecated" (PHP 8.5+)
1 parent 0d1b571 commit c6f22d9

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,11 @@ jobs:
1111
if: "!contains(github.event.head_commit.message, 'skip ci')"
1212
name: PHP ${{ matrix.php-versions }} on ${{ matrix.os }}
1313
runs-on: ${{ matrix.os }}
14-
continue-on-error: ${{ matrix.php-versions >= '8.4' }}
14+
continue-on-error: ${{ matrix.php-versions >= '8.5' }}
1515
strategy:
1616
fail-fast: false
1717
matrix:
18-
php-versions: ['7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4']
18+
php-versions: ['7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5']
1919
os: [ubuntu-latest, windows-latest]
2020

2121
steps:
@@ -48,7 +48,7 @@ jobs:
4848

4949
- name: Install dependencies
5050
run: >
51-
curl -sSL https://baltocdn.com/xp-framework/xp-runners/distribution/downloads/e/entrypoint/xp-run-8.8.0.sh > xp-run &&
51+
curl -sSL https://github.com/xp-runners/reference/releases/download/v9.2.0/xp-run-9.2.0.sh > xp-run &&
5252
composer install --prefer-dist &&
5353
echo "vendor/autoload.php" > composer.pth
5454

ChangeLog.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,12 @@ Data sequences change log
33

44
## ?.?.? / ????-??-??
55

6+
* Fix *Increment on non-numeric string is deprecated* warning in PHP 8.5+
7+
(@thekid)
8+
69
## 10.3.0 / 2024-03-24
710

811
* Made compatible with XP 12 - @thekid
9-
1012
* Added PHP 8.3 and 8.4 to the test matrix - @thekid
1113

1214
## 10.2.0 / 2023-02-23

src/test/php/util/data/unittest/SequenceFlatteningTest.class.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ public function flatten_without_mapper() {
1414
#[Test]
1515
public function flatten_with_mapper() {
1616
$this->assertSequence(['a', 'b', 'c', 'd'], Sequence::of(['a', 'c'])->flatten(function($e) {
17-
return Sequence::iterate($e, function($n) { return ++$n; })->limit(2);
17+
return Sequence::iterate($e, function($n) { return chr(ord($n) + 1); })->limit(2);
1818
}));
1919
}
2020

0 commit comments

Comments
 (0)