Allows for multiple fakes to occur (#67)

Co-authored-by: peterfox <[email protected]>

Author: peterfox

src/Facades/Features.php

@@ -3,6 +3,7 @@
 namespace YlsIdeas\FeatureFlags\Facades;
 
 use Illuminate\Support\Facades\Facade;
+use Illuminate\Support\Testing\Fakes\Fake;
 use YlsIdeas\FeatureFlags\Contracts\Features as FeaturesContract;
 use YlsIdeas\FeatureFlags\Support\FeatureFake;
 
@@ -44,7 +45,11 @@ class Features extends Facade
      */
     public static function fake(array $flagsToFake = []): FeatureFake
     {
-        static::swap($fake = new FeatureFake(static::getFacadeRoot(), $flagsToFake));
+        $manager = static::isFake()
+            ? static::getFacadeRoot()->manager
+            : static::getFacadeRoot();
+
+        static::swap($fake = new FeatureFake($manager, $flagsToFake));
 
         return $fake;
     }

src/FeatureFlagsServiceProvider.php

@@ -109,15 +109,13 @@ protected function schedulingMacros()
             /** @noRector \Rector\Php74\Rector\Closure\ClosureToArrowFunctionRector */
             Event::macro('skipWithoutFeature', fn (string $feature): Event =>
                 /** @var Event $this */
-                /** @phpstan-ignore-next-line annoying issue with macros */
                 $this->skip(fn () => ! Features::accessible($feature)));
         }
 
         if (! Event::hasMacro('skipWithFeature')) {
             /** @noRector \Rector\Php74\Rector\Closure\ClosureToArrowFunctionRector */
             Event::macro('skipWithFeature', fn ($feature): Event =>
                 /** @var Event $this */
-                /** @phpstan-ignore-next-line annoying issue with macros */
                 $this->skip(fn () => Features::accessible($feature)));
         }
     }

src/Support/FeatureFake.php

@@ -4,6 +4,7 @@
 
 use Illuminate\Support\Arr;
 use Illuminate\Support\Facades\Event;
+use Illuminate\Support\Testing\Fakes\Fake;
 use Illuminate\Support\Traits\ForwardsCalls;
 use PHPUnit\Framework\Assert;
 use YlsIdeas\FeatureFlags\Contracts\Features;
@@ -14,7 +15,7 @@
 /**
  * @see \YlsIdeas\FeatureFlags\Tests\Support\FeatureFakeTest
  */
-class FeatureFake implements Features
+class FeatureFake implements Features, Fake
 {
     use ForwardsCalls;
 
@@ -23,7 +24,7 @@ class FeatureFake implements Features
     /**
      * @param array<string, bool|array> $featureFlags
      */
-    public function __construct(protected Manager $manager, protected array $featureFlags = [])
+    public function __construct(public Manager $manager, protected array $featureFlags = [])
     {
     }
 

tests/Support/FeatureFakeTest.php

@@ -148,6 +148,14 @@ public function test_it_fires_events_still()
         Event::assertDispatched(FeatureAccessed::class);
     }
 
+    public function test_it_can_switch_a_feature_multiple_times()
+    {
+        Features::fake(['my-feature' => true]);
+        Features::fake(['my-feature' => false]);
+
+        $this->assertFalse(Features::accessible('my-feature'));
+    }
+
     protected function getFake($manager, $features)
     {
         return new class ($manager, $features) extends FeatureFake {