Remove legacy karpenter_pools_enabled logic (#858)

Signed-off-by: Mikkel Oscar Lyderik Larsen <[email protected]>

Author: mikkeloscar

provisioner/clusterpy.go

@@ -421,53 +421,33 @@ func (p *clusterpyProvisioner) provision(
 		return err
 	}
 
-	if karpenterProvisioner.isKarpenterEnabled() {
-		err = p.apply(
-			ctx,
-			logger,
-			tokenSource,
-			cluster,
-			deletions,
-			manifests,
-			postOptions,
-		)
-		if err != nil {
-			return err
-		}
+	err = p.apply(
+		ctx,
+		logger,
+		tokenSource,
+		cluster,
+		deletions,
+		manifests,
+		postOptions,
+	)
+	if err != nil {
+		return err
 	}
 
-	if karpenterProvisioner.isKarpenterEnabled() {
-		if err = nodePoolGroups["karpenterPools"].provisionNodePoolGroup(ctx, values, updater, cluster, p.applyOnly); err != nil {
-			return err
-		}
+	if err = nodePoolGroups["karpenterPools"].provisionNodePoolGroup(ctx, values, updater, cluster, p.applyOnly); err != nil {
+		return err
 	}
 
 	// clean up removed node pools
 	err = caNodePoolProvisioner.Reconcile(ctx, updater)
 	if err != nil {
 		return err
 	}
-	if karpenterProvisioner.isKarpenterEnabled() {
-		err = karpenterProvisioner.Reconcile(ctx, updater)
-		if err != nil {
-			return err
-		}
+	err = karpenterProvisioner.Reconcile(ctx, updater)
+	if err != nil {
+		return err
 	}
 
-	if !karpenterProvisioner.isKarpenterEnabled() {
-		err = p.apply(
-			ctx,
-			logger,
-			tokenSource,
-			cluster,
-			deletions,
-			manifests,
-			postOptions,
-		)
-		if err != nil {
-			return err
-		}
-	}
 	return nil
 }
 

provisioner/node_pools.go

@@ -234,13 +234,6 @@ func (p *KarpenterNodePoolProvisioner) provisionNodePool(ctx context.Context, no
 	return nil
 }
 
-func (p *KarpenterNodePoolProvisioner) isKarpenterEnabled() bool {
-	if v, found := p.cluster.ConfigItems["karpenter_pools_enabled"]; found && v == "true" {
-		return true
-	}
-	return false
-}
-
 func (p *KarpenterNodePoolProvisioner) Reconcile(ctx context.Context, updater updatestrategy.UpdateStrategy) error {
 	karpenterPools := p.cluster.KarpenterPools()