fix: test case should test for deisred 1 and not nil deployment

Signed-off-by: Sandor Szücs <[email protected]>

Author: szuecs

pkg/core/stack_resources_test.go

@@ -1213,19 +1213,18 @@ func TestStackGenerateService(t *testing.T) {
 
 func TestStackGenerateDeployment(t *testing.T) {
 	for _, tc := range []struct {
-		name                  string
-		hpaEnabled            bool
-		stackReplicas         int32
-		minReadySeconds       int32
-		prescalingActive      bool
-		prescalingReplicas    int32
-		deploymentReplicas    int32
-		noTrafficSince        time.Time
-		expectedReplicas      int32
-		maxUnavailable        int
-		maxSurge              int
-		stackAnnotations      map[string]string
-		expectedDeploymentNil bool
+		name               string
+		hpaEnabled         bool
+		stackReplicas      int32
+		minReadySeconds    int32
+		prescalingActive   bool
+		prescalingReplicas int32
+		deploymentReplicas int32
+		noTrafficSince     time.Time
+		expectedReplicas   int32
+		maxUnavailable     int
+		maxSurge           int
+		stackAnnotations   map[string]string
 	}{
 		{
 			name:               "stack scaled down to zero, deployment still running",
@@ -1360,13 +1359,13 @@ func TestStackGenerateDeployment(t *testing.T) {
 			minReadySeconds: 5,
 		},
 		{
-			name:               "cluster migration should scale down deployment",
+			name:               "cluster migration should scale down deployment to 1",
 			stackReplicas:      3,
 			deploymentReplicas: 3,
 			stackAnnotations: map[string]string{
 				forwardBackendAnnotation: "fwd-deployment",
 			},
-			expectedDeploymentNil: true,
+			expectedReplicas: 1,
 		},
 	} {
 		t.Run(tc.name, func(t *testing.T) {
@@ -1428,10 +1427,6 @@ func TestStackGenerateDeployment(t *testing.T) {
 				}
 			}
 			deployment := c.GenerateDeployment()
-			if tc.expectedDeploymentNil {
-				require.Nil(t, deployment, "Failed to generate nil deployment")
-				return
-			}
 			expected := &apps.Deployment{
 				ObjectMeta: testResourceMeta,
 				Spec: apps.DeploymentSpec{