make local object reference a pointer so it can really be optional (#586)

Author: linki

cmd/e2e/basic_test.go

@@ -167,7 +167,7 @@ func (f *TestStacksetSpecFactory) Create(t *testing.T, stackVersion string) zv1.
 
 		result.StackTemplate.Spec.ConfigurationResources = []zv1.ConfigurationResourcesSpec{
 			{
-				ConfigMapRef: corev1.LocalObjectReference{
+				ConfigMapRef: &corev1.LocalObjectReference{
 					Name: configMapName,
 				},
 			},
@@ -203,7 +203,7 @@ func (f *TestStacksetSpecFactory) Create(t *testing.T, stackVersion string) zv1.
 
 		result.StackTemplate.Spec.ConfigurationResources = []zv1.ConfigurationResourcesSpec{
 			{
-				SecretRef: corev1.LocalObjectReference{
+				SecretRef: &corev1.LocalObjectReference{
 					Name: secretName,
 				},
 			},

controller/stack_resources_test.go

@@ -963,7 +963,7 @@ func TestReconcileStackConfigMap(t *testing.T) {
 		StackSpec: zv1.StackSpec{
 			ConfigurationResources: []zv1.ConfigurationResourcesSpec{
 				{
-					ConfigMapRef: v1.LocalObjectReference{
+					ConfigMapRef: &v1.LocalObjectReference{
 						Name: "foo-v1-test-configmap",
 					},
 				},
@@ -976,12 +976,12 @@ func TestReconcileStackConfigMap(t *testing.T) {
 		StackSpec: zv1.StackSpec{
 			ConfigurationResources: []zv1.ConfigurationResourcesSpec{
 				{
-					ConfigMapRef: v1.LocalObjectReference{
+					ConfigMapRef: &v1.LocalObjectReference{
 						Name: "foo-v1-first-configmap",
 					},
 				},
 				{
-					ConfigMapRef: v1.LocalObjectReference{
+					ConfigMapRef: &v1.LocalObjectReference{
 						Name: "foo-v1-scnd-configmap",
 					},
 				},
@@ -1201,7 +1201,7 @@ func TestReconcileStackSecret(t *testing.T) {
 		StackSpec: zv1.StackSpec{
 			ConfigurationResources: []zv1.ConfigurationResourcesSpec{
 				{
-					SecretRef: v1.LocalObjectReference{
+					SecretRef: &v1.LocalObjectReference{
 						Name: "foo-v1-test-secret",
 					},
 				},
@@ -1214,12 +1214,12 @@ func TestReconcileStackSecret(t *testing.T) {
 		StackSpec: zv1.StackSpec{
 			ConfigurationResources: []zv1.ConfigurationResourcesSpec{
 				{
-					SecretRef: v1.LocalObjectReference{
+					SecretRef: &v1.LocalObjectReference{
 						Name: "foo-v1-test-secret",
 					},
 				},
 				{
-					ConfigMapRef: v1.LocalObjectReference{
+					ConfigMapRef: &v1.LocalObjectReference{
 						Name: "foo-v1-test-configmap",
 					},
 				},
@@ -1232,12 +1232,12 @@ func TestReconcileStackSecret(t *testing.T) {
 		StackSpec: zv1.StackSpec{
 			ConfigurationResources: []zv1.ConfigurationResourcesSpec{
 				{
-					SecretRef: v1.LocalObjectReference{
+					SecretRef: &v1.LocalObjectReference{
 						Name: "foo-v1-first-secret",
 					},
 				},
 				{
-					SecretRef: v1.LocalObjectReference{
+					SecretRef: &v1.LocalObjectReference{
 						Name: "foo-v1-scnd-secret",
 					},
 				},

pkg/apis/zalando.org/v1/types.go

@@ -438,10 +438,10 @@ type StackSpec struct {
 // +k8s:deepcopy-gen=true
 type ConfigurationResourcesSpec struct {
 	// ConfigMap to be owned by Stack
-	ConfigMapRef v1.LocalObjectReference `json:"configMapRef,omitempty"`
+	ConfigMapRef *v1.LocalObjectReference `json:"configMapRef,omitempty"`
 
 	// Secret to be owned by Stack
-	SecretRef v1.LocalObjectReference `json:"secretRef,omitempty"`
+	SecretRef *v1.LocalObjectReference `json:"secretRef,omitempty"`
 }
 
 // GetName returns the name of the ConfigurationResourcesSpec.
@@ -459,12 +459,12 @@ func (crs *ConfigurationResourcesSpec) GetName() string {
 
 // IsConfigMap returns true if the ConfigurationResourcesSpec is a ConfigMap.
 func (crs *ConfigurationResourcesSpec) IsConfigMap() bool {
-	return crs.ConfigMapRef.Name != ""
+	return crs.ConfigMapRef != nil
 }
 
 // IsSecret returns true if the ConfigurationResourcesSpec is a Secret.
 func (crs *ConfigurationResourcesSpec) IsSecret() bool {
-	return crs.SecretRef.Name != ""
+	return crs.SecretRef != nil
 }
 
 // StackSpecInternal is the spec part of the Stack, including `ingress` and