fix: don't expand method snippet in attributes name suggestions. Probably will be adopted instead in future

Author: zardoy

typescript/src/completions/isGoodPositionMethodCompletion.ts

@@ -15,6 +15,7 @@ export const isGoodPositionBuiltinMethodCompletion = (ts: typeof tslib, sourceFi
         if (ts.isJsxSelfClosingElement(currentNode) || ts.isJsxOpeningElement(currentNode)) return false
         if (ts.isShorthandPropertyAssignment(currentNode)) currentNode = currentNode.parent
         if (ts.isObjectBindingPattern(currentNode) || ts.isObjectLiteralExpression(currentNode)) return false
+        if (ts.isJsxAttributes(currentNode) || ts.isJsxAttribute(currentNode)) return false
         if (c('disableMethodSnippets.jsxAttributes') && ts.isJsxExpression(currentNode)) return false
     }
     return true

typescript/src/index.ts

@@ -85,7 +85,7 @@ export = ({ typescript }: { typescript: typeof ts }) => {
                 if (
                     c('enableMethodSnippets') &&
                     oneOf(
-                        prior.kind as string,
+                        prior.kind,
                         ts.ScriptElementKind.constElement,
                         ts.ScriptElementKind.letElement,
                         ts.ScriptElementKind.alias,

typescript/test/completions.spec.ts

@@ -68,6 +68,9 @@ test('Builtin method snippet banned positions', () => {
         ;<Test/*|*/></Test>
         ;<Test test={/*|*/}></Test>
         ;<Test test={a/*|*/}></Test>
+        ;<Test /*|*/></Test>
+        ;<Test a={5} /*|*/ b></Test>
+        ;<Test a/*|*/ />
     `)
     for (const [i, pos] of cursorPositions.entries()) {
         const result = isGoodPositionBuiltinMethodCompletion(ts, getSourceFile(), pos, defaultConfigFunc)
@@ -90,6 +93,9 @@ test('Additional banned positions for our method snippets', () => {
         ;<Test/*|*/></Test>
         ;<Test test={/*|*/}></Test>
         ;<Test test={a/*|*/}></Test>
+        ;<Test /*|*/></Test>
+        ;<Test a={5} /*|*/ b></Test>
+        ;<Test a/*|*/ />
     `)
     for (const [i, pos] of cursorPositions.entries()) {
         const result = isGoodPositionMethodCompletion(ts, entrypoint, getSourceFile(), pos - 1, languageService, defaultConfigFunc)