Merge pull request isaacphi#13 from virtuald/hover-retry

Retry hover requests

Author: virtuald

integrationtests/snapshots/rust/hover/struct-type.snap

@@ -6,7 +6,4 @@ pub struct TestStruct {
 }
 
 
-size = 32 (0x20), align = 0x8
-
-
-contain types with destructors (drop glue); doesn't have a destructor
+size = 32 (0x20), align = 0x8, needs Drop

internal/lsp/transport.go

@@ -4,18 +4,25 @@ import (
 	"bufio"
 	"context"
 	"encoding/json"
+	"errors"
 	"fmt"
 	"io"
 	"strings"
 
 	"github.com/isaacphi/mcp-language-server/internal/logging"
+	"github.com/isaacphi/mcp-language-server/internal/protocol"
 )
 
 // Create component-specific loggers
 var lspLogger = logging.NewLogger(logging.LSP)
 var wireLogger = logging.NewLogger(logging.LSPWire)
 var processLogger = logging.NewLogger(logging.LSPProcess)
 
+var (
+	ErrContentModified = errors.New("content modified")
+	ErrServerCancelled = errors.New("server cancelled")
+)
+
 // WriteMessage writes an LSP message to the given writer
 func WriteMessage(w io.Writer, msg *Message) error {
 	data, err := json.Marshal(msg)
@@ -230,7 +237,14 @@ func (c *Client) Call(ctx context.Context, method string, params any, result any
 
 	if resp.Error != nil {
 		lspLogger.Error("Request failed: %s (code: %d)", resp.Error.Message, resp.Error.Code)
-		return fmt.Errorf("request failed: %s (code: %d)", resp.Error.Message, resp.Error.Code)
+		switch protocol.LSPErrorCodes(resp.Error.Code) {
+		case protocol.ContentModified:
+			return ErrContentModified
+		case protocol.ServerCancelled:
+			return ErrServerCancelled
+		default:
+			return fmt.Errorf("request failed: %s (code: %d)", resp.Error.Message, resp.Error.Code)
+		}
 	}
 
 	if result != nil {

internal/tools/hover.go

@@ -2,6 +2,7 @@ package tools
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"strings"
 
@@ -31,9 +32,17 @@ func GetHoverInfo(ctx context.Context, client *lsp.Client, filePath string, line
 	params.Position = position
 
 	// Execute the hover request
-	hoverResult, err := client.Hover(ctx, params)
-	if err != nil {
-		return "", fmt.Errorf("failed to get hover information: %v", err)
+	// - some LSP (rust) will return "content modified", so retry it
+	var hoverResult protocol.Hover
+	for i := range 3 {
+		hoverResult, err = client.Hover(ctx, params)
+		if err == nil {
+			break
+		} else if errors.Is(err, lsp.ErrContentModified) {
+			continue
+		} else if i == 2 {
+			return "", fmt.Errorf("failed to get hover information: %v", err)
+		}
 	}
 
 	var result strings.Builder