From 9356a8ba1f5c0d851abe48839c9fa14a711bc046 Mon Sep 17 00:00:00 2001 From: aadityasinha-dotcom Date: Thu, 11 Sep 2025 22:42:33 +0530 Subject: [PATCH 01/10] replaced commentjson with json5 to remove block comments Signed-off-by: aadityasinha-dotcom --- src/core/zowe/core_for_zowe_sdk/config_file.py | 6 +++--- src/core/zowe/core_for_zowe_sdk/credential_manager.py | 6 +++--- src/core/zowe/core_for_zowe_sdk/validators.py | 9 ++++----- 3 files changed, 10 insertions(+), 11 deletions(-) diff --git a/src/core/zowe/core_for_zowe_sdk/config_file.py b/src/core/zowe/core_for_zowe_sdk/config_file.py index 3de941ad..621f62d2 100644 --- a/src/core/zowe/core_for_zowe_sdk/config_file.py +++ b/src/core/zowe/core_for_zowe_sdk/config_file.py @@ -18,7 +18,7 @@ from dataclasses import dataclass, field from typing import NamedTuple, Optional, Any, Union -import commentjson +import json5 import requests from .credential_manager import CredentialManager @@ -136,7 +136,7 @@ def init_from_file( return with open(self.filepath, encoding="UTF-8", mode="r") as fileobj: - profile_jsonc = commentjson.load(fileobj) + profile_jsonc = json5.load(fileobj) self.profiles = profile_jsonc.get("profiles", {}) if profile_jsonc.get("profiles", {}) is not None else [] self.schema_property = profile_jsonc.get("$schema", None) @@ -629,7 +629,7 @@ def save(self, update_secure_props: Optional[bool] = True) -> None: CredentialManager.secure_props[self.filepath] = secure_props with open(self.filepath, "w") as file: self.jsonc["profiles"] = profiles_temp - commentjson.dump(self.jsonc, file, indent=4) + json5.dump(self.jsonc, file, indent=4) if update_secure_props: CredentialManager.save_secure_props() diff --git a/src/core/zowe/core_for_zowe_sdk/credential_manager.py b/src/core/zowe/core_for_zowe_sdk/credential_manager.py index c6030270..a345a696 100644 --- a/src/core/zowe/core_for_zowe_sdk/credential_manager.py +++ b/src/core/zowe/core_for_zowe_sdk/credential_manager.py @@ -14,7 +14,7 @@ import sys from typing import Optional, Any -import commentjson +import json5 from .constants import constants from .exceptions import SecureProfileLoadFailed @@ -63,7 +63,7 @@ def load_secure_props() -> None: secure_config: bytes secure_config = secret_value.encode() - secure_config_json = commentjson.loads(base64.b64decode(secure_config).decode()) + secure_config_json = json5.loads(base64.b64decode(secure_config).decode()) # update the secure props CredentialManager.secure_props = secure_config_json @@ -76,7 +76,7 @@ def save_secure_props() -> None: credential = CredentialManager.secure_props # Check if credential is a non-empty string if credential: - encoded_credential = base64.b64encode(commentjson.dumps(credential).encode()).decode() + encoded_credential = base64.b64encode(json5.dumps(credential).encode()).decode() if sys.platform == "win32": # Delete the existing credential CredentialManager._delete_credential( diff --git a/src/core/zowe/core_for_zowe_sdk/validators.py b/src/core/zowe/core_for_zowe_sdk/validators.py index df366f74..696f29ba 100644 --- a/src/core/zowe/core_for_zowe_sdk/validators.py +++ b/src/core/zowe/core_for_zowe_sdk/validators.py @@ -13,7 +13,7 @@ import os from typing import Union, Any -import commentjson +import json5 import requests from jsonschema import validate @@ -38,13 +38,12 @@ def validate_config_json(path_config_json: Union[str, dict[str, Any]], path_sche # checks if the path_schema_json is a file elif os.path.isfile(path_schema_json) or path_schema_json.startswith("file://"): with open(path_schema_json.replace("file://", "")) as file: - schema_json = commentjson.load(file) - + schema_json = json5.load(file) # checks if the path_schema_json is absolute elif not os.path.isabs(path_schema_json): path_schema_json = os.path.join(cwd, path_schema_json) with open(path_schema_json) as file: - schema_json = commentjson.load(file) + schema_json = json5.load(file) # if there is no path_schema_json it will return None else: @@ -52,7 +51,7 @@ def validate_config_json(path_config_json: Union[str, dict[str, Any]], path_sche if isinstance(path_config_json, str): with open(path_config_json) as file: - config_json = commentjson.load(file) + config_json = json5.load(file) else: config_json = path_config_json From d6a03e4f0d2323d8dee4d2041bed60a38bf37ae7 Mon Sep 17 00:00:00 2001 From: aadityasinha-dotcom Date: Thu, 11 Sep 2025 22:44:34 +0530 Subject: [PATCH 02/10] changes to the tests as well Signed-off-by: aadityasinha-dotcom --- tests/unit/core/test_config.py | 18 +++++++++--------- tests/unit/core/test_profile_manager.py | 22 +++++++++++----------- 2 files changed, 20 insertions(+), 20 deletions(-) diff --git a/tests/unit/core/test_config.py b/tests/unit/core/test_config.py index e4172931..e5df6ad3 100644 --- a/tests/unit/core/test_config.py +++ b/tests/unit/core/test_config.py @@ -1,7 +1,7 @@ import importlib.util import os -import commentjson +import json5 from jsonschema import ValidationError, validate from pyfakefs.fake_filesystem_unittest import TestCase from zowe.core_for_zowe_sdk.validators import validate_config_json @@ -36,8 +36,8 @@ def setUp(self): def test_validate_config_json_valid(self): """Test validate_config_json with valid config.json matching schema.json""" - config_json = commentjson.load(open(self.original_file_path)) - schema_json = commentjson.load(open(self.original_schema_file_path)) + config_json = json5.load(open(self.original_file_path)) + schema_json = json5.load(open(self.original_schema_file_path)) expected = validate(config_json, schema_json) result = validate_config_json(self.original_file_path, self.original_schema_file_path, cwd=FIXTURES_PATH) @@ -51,17 +51,17 @@ def test_validate_config_json_invalid(self): path_to_invalid_schema = os.path.join(custom_dir, "invalid.zowe.schema.json") with open(self.original_file_path, "r") as f: - original_config = commentjson.load(f) + original_config = json5.load(f) original_config["$schema"] = "invalid.zowe.schema.json" original_config["profiles"]["zosmf"]["properties"]["port"] = "10443" with open(path_to_invalid_config, "w") as f: - commentjson.dump(original_config, f) + json5.dump(original_config, f) with open(self.original_schema_file_path, "r") as f: - original_schema = commentjson.load(f) + original_schema = json5.load(f) with open(path_to_invalid_schema, "w") as f: - commentjson.dump(original_schema, f) - invalid_config_json = commentjson.load(open(path_to_invalid_config)) - invalid_schema_json = commentjson.load(open(path_to_invalid_schema)) + json5.dump(original_schema, f) + invalid_config_json = json5.load(open(path_to_invalid_config)) + invalid_schema_json = json5.load(open(path_to_invalid_schema)) with self.assertRaises(ValidationError) as expected_info: validate(invalid_config_json, invalid_schema_json) diff --git a/tests/unit/core/test_profile_manager.py b/tests/unit/core/test_profile_manager.py index d36e3d94..6c382396 100644 --- a/tests/unit/core/test_profile_manager.py +++ b/tests/unit/core/test_profile_manager.py @@ -8,7 +8,7 @@ import shutil from unittest import mock -import commentjson +import json5 from jsonschema import SchemaError, ValidationError from pyfakefs.fake_filesystem_unittest import TestCase from zowe.core_for_zowe_sdk import ( @@ -348,7 +348,7 @@ def test_load_secure_props(self, retrieve_cred_func): cwd_up_file_path: {"profiles.base.properties.user": "user", "profiles.base.properties.password": "password"} } self.setUpCreds(cwd_up_file_path, credential) - encoded_credential = base64.b64encode(commentjson.dumps(credential).encode()).decode() + encoded_credential = base64.b64encode(json5.dumps(credential).encode()).decode() retrieve_cred_func.return_value = encoded_credential # call the load_secure_props method @@ -524,15 +524,15 @@ def test_profile_loading_with_invalid_schema(self, get_pass_func): with self.assertRaises(ValidationError): custom_file_path = os.path.join(self.custom_dir, "zowe.config.json") with open(self.original_file_path, "r") as f: - original_config = commentjson.load(f) + original_config = json5.load(f) original_config["$schema"] = "invalid.zowe.schema.json" original_config["profiles"]["zosmf"]["properties"]["port"] = "10443" with open(os.path.join(self.custom_dir, "invalid.zowe.config.json"), "w") as f: - commentjson.dump(original_config, f) + json5.dump(original_config, f) with open(self.original_schema_file_path, "r") as f: - original_schema = commentjson.load(f) + original_schema = json5.load(f) with open(os.path.join(self.custom_dir, "invalid.zowe.schema.json"), "w") as f: - commentjson.dump(original_schema, f) + json5.dump(original_schema, f) self.setUpCreds( custom_file_path, { @@ -555,15 +555,15 @@ def test_profile_loading_with_invalid_schema_internet_URI(self, get_pass_func): with self.assertRaises(SchemaError): custom_file_path = os.path.join(self.custom_dir, "zowe.config.json") with open(self.original_file_path, "r") as f: - original_config = commentjson.load(f) + original_config = json5.load(f) original_config["$schema"] = "invalidUri.zowe.schema.json" with open(os.path.join(self.custom_dir, "invalidUri.zowe.config.json"), "w") as f: - commentjson.dump(original_config, f) + json5.dump(original_config, f) with open(self.original_schema_file_path, "r") as f: - original_schema = commentjson.load(f) + original_schema = json5.load(f) original_schema["type"] = "invalid" with open(os.path.join(self.custom_dir, "invalidUri.zowe.schema.json"), "w") as f: - commentjson.dump(original_schema, f) + json5.dump(original_schema, f) self.setUpCreds( custom_file_path, @@ -840,4 +840,4 @@ def test_find_profile_with_non_dict_value(): valid_result = config_file.find_profile("valid_profile", profiles) assert valid_result is not None - assert valid_result["type"] == "zosmf" \ No newline at end of file + assert valid_result["type"] == "zosmf" From b142cf6c4726a728e875618cc055cfc380ecf06c Mon Sep 17 00:00:00 2001 From: aadityasinha-dotcom Date: Wed, 15 Oct 2025 23:02:41 +0530 Subject: [PATCH 03/10] changes requested Signed-off-by: aadityasinha-dotcom --- README.md | 2 +- requirements.txt | 2 +- src/core/setup.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index f437add1..c0cfcda4 100644 --- a/README.md +++ b/README.md @@ -48,7 +48,7 @@ For more information on the available sub-packages click [HERE](https://zowe-cli The Zowe core package has dependencies on the packages listed below: ``` -commentjson +json5 deepmerge jsonschema pyyaml diff --git a/requirements.txt b/requirements.txt index b3846183..e099f00f 100644 --- a/requirements.txt +++ b/requirements.txt @@ -1,4 +1,4 @@ -commentjson==0.9.0 +json5==0.12.1 deepmerge==1.1.0 jsonschema==4.17.3 PyYAML==6.0.1 diff --git a/src/core/setup.py b/src/core/setup.py index 736af552..67ff4887 100644 --- a/src/core/setup.py +++ b/src/core/setup.py @@ -34,7 +34,7 @@ "License :: OSI Approved :: Eclipse Public License 2.0 (EPL-2.0)", ], install_requires=[ - "commentjson~=0.9.0", + "json5~=0.12.1" "deepmerge~=1.1.0", "jsonschema~=4.17.3", "pyyaml~=6.0.1", From b24aca0d7614961331d5528bb992118761184f9d Mon Sep 17 00:00:00 2001 From: Aaditya Sinha <75474786+aadityasinha-dotcom@users.noreply.github.com> Date: Fri, 17 Oct 2025 20:59:23 +0530 Subject: [PATCH 04/10] Update src/core/setup.py Co-authored-by: Timothy Johnson Signed-off-by: Aaditya Sinha <75474786+aadityasinha-dotcom@users.noreply.github.com> --- src/core/setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/setup.py b/src/core/setup.py index 41f4c146..c8820cdd 100644 --- a/src/core/setup.py +++ b/src/core/setup.py @@ -34,7 +34,7 @@ "License :: OSI Approved :: Eclipse Public License 2.0 (EPL-2.0)", ], install_requires=[ - "json5~=0.12.1" + "json5~=0.12.1", "deepmerge~=1.1.0", "jsonschema~=4.17.3", "pyyaml~=6.0.1", From a6bdaa3ec7a9cd5038068f1ae3f01dcc3c357cd2 Mon Sep 17 00:00:00 2001 From: aadityasinha-dotcom Date: Thu, 23 Oct 2025 22:05:00 +0530 Subject: [PATCH 05/10] added unit test Signed-off-by: aadityasinha-dotcom --- tests/unit/core/test_config.py | 69 ++++++++++++++++++++++++++++++++++ 1 file changed, 69 insertions(+) diff --git a/tests/unit/core/test_config.py b/tests/unit/core/test_config.py index e5df6ad3..2fe193df 100644 --- a/tests/unit/core/test_config.py +++ b/tests/unit/core/test_config.py @@ -70,3 +70,72 @@ def test_validate_config_json_invalid(self): validate_config_json(path_to_invalid_config, path_to_invalid_schema, cwd=FIXTURES_PATH) self.assertEqual(str(actual_info.exception), str(expected_info.exception)) + + def test_validate_config_json_with_block_comments(self): + """Config with /* block comments */ should load and validate.""" + custom_dir = os.path.dirname(FIXTURES_PATH) + commented_config_path = os.path.join(custom_dir, "commented.zowe.config.json") + commented_schema_path = os.path.join(custom_dir, "commented.zowe.schema.json") + + schema_text = """ + { + /* Top-level block comment in schema */ + "$schema": "http://json-schema.org/draft-07/schema#", + "type": "object", + "properties": { + "$schema": { "type": "string" }, + "profiles": { + "type": "object", + "properties": { + "zosmf": { + "type": "object", + "properties": { + "properties": { + "type": "object", + "properties": { + "host": { "type": "string" }, + "port": { "type": "integer" } + }, + "required": ["host", "port"] + } + }, + "required": ["properties"] + } + }, + "required": ["zosmf"] + } + }, + "required": ["$schema", "profiles"] + } + """ + + config_text = """ + { + /* Block comment before schema reference */ + "$schema": "commented.zowe.schema.json", + "profiles": { + /* Block comment inside profiles */ + "zosmf": { + "properties": { + "host": "localhost", + /* Inline block comment between fields */ + "port": 10443, /* trailing comma tolerated by JSON5 */ + }, + }, + } + } + """ + + # Write files to the fake FS + with open(commented_schema_path, "w", encoding="utf-8") as f: + f.write(schema_text) + with open(commented_config_path, "w", encoding="utf-8") as f: + f.write(config_text) + + loaded_config = json5.load(open(commented_config_path, encoding="utf-8")) + loaded_schema = json5.load(open(commented_schema_path, encoding="utf-8")) + + expected = validate(loaded_config, loaded_schema) + result = validate_config_json(commented_config_path, commented_schema_path, cwd=os.path.dirname(commented_config_path)) + + self.assertEqual(result, expected) From 83b75cd4afd80a1020da0b211a5aa02d822c71d4 Mon Sep 17 00:00:00 2001 From: aadityasinha-dotcom Date: Thu, 23 Oct 2025 23:34:42 +0530 Subject: [PATCH 06/10] fixed tests Signed-off-by: aadityasinha-dotcom --- tests/unit/core/test_profile_manager.py | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/tests/unit/core/test_profile_manager.py b/tests/unit/core/test_profile_manager.py index 6c382396..cb5b534b 100644 --- a/tests/unit/core/test_profile_manager.py +++ b/tests/unit/core/test_profile_manager.py @@ -8,7 +8,7 @@ import shutil from unittest import mock -import json5 +import commentjson from jsonschema import SchemaError, ValidationError from pyfakefs.fake_filesystem_unittest import TestCase from zowe.core_for_zowe_sdk import ( @@ -348,7 +348,7 @@ def test_load_secure_props(self, retrieve_cred_func): cwd_up_file_path: {"profiles.base.properties.user": "user", "profiles.base.properties.password": "password"} } self.setUpCreds(cwd_up_file_path, credential) - encoded_credential = base64.b64encode(json5.dumps(credential).encode()).decode() + encoded_credential = base64.b64encode(commentjson.dumps(credential).encode()).decode() retrieve_cred_func.return_value = encoded_credential # call the load_secure_props method @@ -524,15 +524,15 @@ def test_profile_loading_with_invalid_schema(self, get_pass_func): with self.assertRaises(ValidationError): custom_file_path = os.path.join(self.custom_dir, "zowe.config.json") with open(self.original_file_path, "r") as f: - original_config = json5.load(f) + original_config = commentjson.load(f) original_config["$schema"] = "invalid.zowe.schema.json" original_config["profiles"]["zosmf"]["properties"]["port"] = "10443" with open(os.path.join(self.custom_dir, "invalid.zowe.config.json"), "w") as f: - json5.dump(original_config, f) + commentjson.dump(original_config, f) with open(self.original_schema_file_path, "r") as f: - original_schema = json5.load(f) + original_schema = commentjson.load(f) with open(os.path.join(self.custom_dir, "invalid.zowe.schema.json"), "w") as f: - json5.dump(original_schema, f) + commentjson.dump(original_schema, f) self.setUpCreds( custom_file_path, { @@ -555,15 +555,15 @@ def test_profile_loading_with_invalid_schema_internet_URI(self, get_pass_func): with self.assertRaises(SchemaError): custom_file_path = os.path.join(self.custom_dir, "zowe.config.json") with open(self.original_file_path, "r") as f: - original_config = json5.load(f) + original_config = commentjson.load(f) original_config["$schema"] = "invalidUri.zowe.schema.json" with open(os.path.join(self.custom_dir, "invalidUri.zowe.config.json"), "w") as f: - json5.dump(original_config, f) + commentjson.dump(original_config, f) with open(self.original_schema_file_path, "r") as f: - original_schema = json5.load(f) + original_schema = commentjson.load(f) original_schema["type"] = "invalid" with open(os.path.join(self.custom_dir, "invalidUri.zowe.schema.json"), "w") as f: - json5.dump(original_schema, f) + commentjson.dump(original_schema, f) self.setUpCreds( custom_file_path, From e34e71e6dc83efec88a6e71ef8b3c55f8a59844d Mon Sep 17 00:00:00 2001 From: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Date: Mon, 27 Oct 2025 10:35:26 -0400 Subject: [PATCH 07/10] test: help with tests :yum: Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> --- tests/unit/core/test_profile_manager.py | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/tests/unit/core/test_profile_manager.py b/tests/unit/core/test_profile_manager.py index cb5b534b..1e797a43 100644 --- a/tests/unit/core/test_profile_manager.py +++ b/tests/unit/core/test_profile_manager.py @@ -8,7 +8,7 @@ import shutil from unittest import mock -import commentjson +import json5 from jsonschema import SchemaError, ValidationError from pyfakefs.fake_filesystem_unittest import TestCase from zowe.core_for_zowe_sdk import ( @@ -348,7 +348,7 @@ def test_load_secure_props(self, retrieve_cred_func): cwd_up_file_path: {"profiles.base.properties.user": "user", "profiles.base.properties.password": "password"} } self.setUpCreds(cwd_up_file_path, credential) - encoded_credential = base64.b64encode(commentjson.dumps(credential).encode()).decode() + encoded_credential = base64.b64encode(json5.dumps(credential).encode()).decode() retrieve_cred_func.return_value = encoded_credential # call the load_secure_props method @@ -446,7 +446,7 @@ def test_save_secure_props_normal_credential(self, delete_pass_func, retrieve_cr } } self.setUpCreds(cwd_up_file_path, credential) - encoded_credential = base64.b64encode(commentjson.dumps(credential).encode()).decode() + encoded_credential = base64.b64encode(json5.dumps(credential).encode()).decode() retrieve_cred_func.return_value = None CredentialManager.secure_props = credential @@ -474,7 +474,7 @@ def test_save_secure_props_exceed_limit(self, delete_pass_func, set_pass_func, r } } self.setUpCreds(cwd_up_file_path, credential) - encoded_credential = base64.b64encode(commentjson.dumps(credential).encode()).decode() + encoded_credential = base64.b64encode(json5.dumps(credential).encode()).decode() encoded_credential += "\0" retrieve_cred_func.return_value = encoded_credential @@ -524,15 +524,15 @@ def test_profile_loading_with_invalid_schema(self, get_pass_func): with self.assertRaises(ValidationError): custom_file_path = os.path.join(self.custom_dir, "zowe.config.json") with open(self.original_file_path, "r") as f: - original_config = commentjson.load(f) + original_config = json5.load(f) original_config["$schema"] = "invalid.zowe.schema.json" original_config["profiles"]["zosmf"]["properties"]["port"] = "10443" with open(os.path.join(self.custom_dir, "invalid.zowe.config.json"), "w") as f: - commentjson.dump(original_config, f) + json5.dump(original_config, f) with open(self.original_schema_file_path, "r") as f: - original_schema = commentjson.load(f) + original_schema = json5.load(f) with open(os.path.join(self.custom_dir, "invalid.zowe.schema.json"), "w") as f: - commentjson.dump(original_schema, f) + json5.dump(original_schema, f) self.setUpCreds( custom_file_path, { @@ -555,15 +555,15 @@ def test_profile_loading_with_invalid_schema_internet_URI(self, get_pass_func): with self.assertRaises(SchemaError): custom_file_path = os.path.join(self.custom_dir, "zowe.config.json") with open(self.original_file_path, "r") as f: - original_config = commentjson.load(f) + original_config = json5.load(f) original_config["$schema"] = "invalidUri.zowe.schema.json" with open(os.path.join(self.custom_dir, "invalidUri.zowe.config.json"), "w") as f: - commentjson.dump(original_config, f) + json5.dump(original_config, f) with open(self.original_schema_file_path, "r") as f: - original_schema = commentjson.load(f) + original_schema = json5.load(f) original_schema["type"] = "invalid" with open(os.path.join(self.custom_dir, "invalidUri.zowe.schema.json"), "w") as f: - commentjson.dump(original_schema, f) + json5.dump(original_schema, f) self.setUpCreds( custom_file_path, From 17cb67b4130b18cea1dde1463da0613ebb41770b Mon Sep 17 00:00:00 2001 From: aadityasinha-dotcom Date: Mon, 27 Oct 2025 20:12:01 +0530 Subject: [PATCH 08/10] added changelog Signed-off-by: aadityasinha-dotcom --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 743b7943..27cf1519 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,10 @@ All notable changes to the Zowe Client Python SDK will be documented in this fil - Updated the `pyo3` dependency of the Secrets SDK for technical currency. [#355](https://github.com/zowe/zowe-client-python-sdk/pull/355) - Updated the `urllib3` dependency of the Core SDK for technical currency. [#370](https://github.com/zowe/zowe-client-python-sdk/pull/370) +### Enhancements + +- Replaced commentjson with json5 to support block comments. [#374](https://github.com/zowe/zowe-client-python-sdk/pull/374) + ## `1.0.0-dev22` ### Enhancements From 81ac440bcbdbfb3c65301086c3106d677088cde8 Mon Sep 17 00:00:00 2001 From: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Date: Mon, 27 Oct 2025 13:19:04 -0400 Subject: [PATCH 09/10] chore: moved things around in the changelog :yum: Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> --- CHANGELOG.md | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 27cf1519..2f8f556b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,21 +2,25 @@ All notable changes to the Zowe Client Python SDK will be documented in this file. +## Recent Changes + +### Enhancements + +- Replaced `commentjson` with `json5` to support block comments. [#374](https://github.com/zowe/zowe-client-python-sdk/pull/374) + ## `1.0.0-dev23` -- Fixed missing and incorrect type annotations. [#321](https://github.com/zowe/zowe-client-python-sdk/issues/321) +### Enhancements + - Removed the `suppress_config_file_warnings` parameter from individual functions. [#365](https://github.com/zowe/zowe-client-python-sdk/issues/365) - Introduced the class-wide property `suppress_config_file_warnings` to control configuration file warnings. [#365](https://github.com/zowe/zowe-client-python-sdk/issues/365) ### Bug Fixes +- Fixed missing and incorrect type annotations. [#321](https://github.com/zowe/zowe-client-python-sdk/issues/321) - Updated the `pyo3` dependency of the Secrets SDK for technical currency. [#355](https://github.com/zowe/zowe-client-python-sdk/pull/355) - Updated the `urllib3` dependency of the Core SDK for technical currency. [#370](https://github.com/zowe/zowe-client-python-sdk/pull/370) -### Enhancements - -- Replaced commentjson with json5 to support block comments. [#374](https://github.com/zowe/zowe-client-python-sdk/pull/374) - ## `1.0.0-dev22` ### Enhancements From 909fc5b9c8c20272eae1dc9b8158a515bbd245b5 Mon Sep 17 00:00:00 2001 From: Aaditya Sinha <75474786+aadityasinha-dotcom@users.noreply.github.com> Date: Mon, 27 Oct 2025 23:41:40 +0530 Subject: [PATCH 10/10] Update CHANGELOG.md Co-authored-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Signed-off-by: Aaditya Sinha <75474786+aadityasinha-dotcom@users.noreply.github.com> --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0ab8206a..d557cec3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,7 +7,7 @@ All notable changes to the Zowe Client Python SDK will be documented in this fil ### Enhancements - Added z/OSMF Workflows functionality. [#372](https://github.com/zowe/zowe-client-python-sdk/pull/372) -- Replaced `commentjson` with `json5` to support block comments. [#374](https://github.com/zowe/zowe-client-python-sdk/pull/374) +- Replaced the `commentjson` package with the `json5` package to support block comments. [#374](https://github.com/zowe/zowe-client-python-sdk/pull/374) ### Bug Fixes