EnableAllFilters() and DisableAllFilters() breaks conditionally enabled filters

[mlyczek]

DynamicFilters version: 3.0.1
EntityFramework version: 6.1.3
Database version: SQL Server 2014

Example with failing unit test: https://github.com/mlyczek/EF.DynamicFilters.ConditionalEnableIssue

Hi, we are using EntityFramework.DynamicFilters in our project and it works great. But currently we want to use Conditionally Enabling Filters and we found out that there is probably an issue with it. In our project we use the DisableAllFilters() and EnableAllFilters() extension methods on DbContext in some scenarios where we want temporarily disable all our filters. The problem is that even after calling EnableAllFilters() our conditional filters are no longer calling the condition lambda to check whether they should be enabled or not. From that point those filters are always enabled.

In the repository linked above there is a test project where one test is failing to demonstrate the issue.

After a little debugging it looks like it is caused by the DisableAllFilters() and EnableAllFilters() methods. Both of them are calling GetOrCreateScopedFilterParameters() to get or create a scoped filter parameters definition in order to disable/enable the filter. The problem is that those scoped parameters definition doesn't have the EnableIfCondition property copied from original filter. And therefore while checking if the filter is enabled in IsFilterEnabled() that scoped parameters definition is found without EnableIfCondition and therefore IsFilterEnabled() returns true without calling the condition delegate.

Thanks in advance for looking into this issue.

[JonathanMagnan]

Hello @mlyczek

Thank you for reporting, we successfully reproduced it with your test issue.

Thank also for the additional information about the cause,

We will continue to look at it tomorrow.

Best Regards,

Jonathan

[md-tayeb-himel]

@JonathanMagnan is there any updated regarding this issue?

[JonathanMagnan]

Hello @himel951 ,

I do not think this issue will be fixed soon or ever. We don't put any focus on this library at this moment.

[md-tayeb-himel]

Thanks for the reply @JonathanMagnan

[md-tayeb-himel]

@JonathanMagnan just wants to know, is there any workaround you know that can help us to mitigate the issue.

Currently, we have global for IsDeleted = 'false' but we have a situation where we need to have the deleted value.

Because of the global filter, we cant archive it. If somehow you can show us the right direction it would be very helpful. Thanks

[JonathanMagnan]

Hello @himel951 ,

It has been too long since we investigated this issue, so if there was a workaround, I don't remember it anymore ;(