-
-
Notifications
You must be signed in to change notification settings - Fork 898
feat: use uv for dependency installation in build script #1942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Update build_mkdocs.sh to install uv first, then use it for installing both core and documentation dependencies. This allows testing uv in the Cloudflare Workers build environment. 🤖 Generated with Claude Code Co-Authored-By: Claude <[email protected]>
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
instructor | dc3957a | Nov 22 2025, 04:01 PM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to dc3957a in 41 seconds. Click for details.
- Reviewed
11lines of code in1files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. build_mkdocs.sh:1
- Draft comment:
Consider pinning the 'uv' version (e.g., uv==x.y.z) to ensure reproducible builds. - Reason this comment was not posted:
Confidence changes required:50%<= threshold85%None
2. build_mkdocs.sh:2
- Draft comment:
DRY improvement: Consider iterating over requirements files to avoid duplicating similar uv pip install commands. - Reason this comment was not posted:
Confidence changes required:50%<= threshold85%None
3. build_mkdocs.sh:1
- Draft comment:
Consider adding error handling (e.g., 'set -e') at the start of the script so that build_mkdocs.sh stops if any installation command fails. - Reason this comment was not posted:
Confidence changes required:50%<= threshold85%None
Workflow ID: wflow_TxIttsf7Fw96AmxF
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| uv pip install -r requirements.txt | ||
| uv pip install -r requirements-doc.txt | ||
| mkdocs build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MkDocs runs outside uv-installed environment
When this script is invoked from a clean shell (no virtualenv active), uv pip install -r requirements*.txt on lines 2–3 creates a .venv and installs dependencies there by default, but mkdocs build on line 4 is executed with the system interpreter. In that context the MkDocs entrypoint and plugins stay inside the uv-managed venv, so the build fails with mkdocs: command not found or missing modules—something that did not happen with the previous system-level pip install. To keep the docs build working in CI/Cloudflare, the script needs to run MkDocs via the uv environment (e.g., uv run mkdocs build or --system).
Useful? React with 👍 / 👎.
Summary
Update build_mkdocs.sh to use uv for installing dependencies instead of pip directly.
Changes
uv pip installfor both requirements.txt and requirements-doc.txtTesting
Deploy this branch to Cloudflare to verify uv works in the build environment.
🤖 Generated with Claude Code
Important
Update
build_mkdocs.shto useuvfor dependency installation instead ofpipdirectly.build_mkdocs.shto useuvfor dependency installation instead ofpipdirectly.uvviapipfirst, then useuv pip installforrequirements.txtandrequirements-doc.txt.uvin the Cloudflare Workers build environment.This description was created by
for dc3957a. You can customize this summary. It will automatically update as commits are pushed.