Skip to content

Conversation

@LeonVreling
Copy link
Member

It would be nice to have this information sent as an email, but it cannot hurt to also already display it on the frontend

It would be nice to have this information sent as an email, but it cannot hurt to also already display it on the frontend
@LeonVreling LeonVreling requested a review from WikiRik March 17, 2025 16:18
I didn't know this relation attribute was mandatory for security reasons
@WikiRik
Copy link
Member

WikiRik commented Mar 17, 2025

Can you share a screenshot on how it'd look like with a mobile screen? I'm worried about having too much information here. And people that might forget to save once they open the templates
It might be better to add this information in the email; https://github.com/AEGEE/mailer/blob/stable/lib/omsmailer_web/templates/page/network_board_welcome.html.eex

@LeonVreling
Copy link
Member Author

image
This is how it would look on my phone, so covering almost the full height of the modal.

I think it could also be added to the email, but probably wouldn't hurt to remind people more often

@WikiRik WikiRik merged commit 6e1d568 into stable Mar 18, 2025
4 checks passed
@WikiRik WikiRik deleted the add-info-board-change branch March 18, 2025 17:49
serge1peshcoff pushed a commit that referenced this pull request Mar 18, 2025
## [1.42.17](1.42.16...1.42.17) (2025-03-18)

### Bug Fixes

* **network:** add information about needed documents to board change ([#2327](#2327)) ([6e1d568](6e1d568))
@serge1peshcoff
Copy link
Member

🎉 This PR is included in version 1.42.17 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants