Refactor grid-stride loop #4190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeiqunZhang
force-pushed
the
grid-stride-loop
branch
2 times, most recently
from
168b2c4 to
f2af094
Compare
Move grid-stride loop out of GPU kernels. @ashesh2512 noticed performance issues with grid-stride loops on AMD GPUs in PelePhyscis's large kernels. Thank @AlexanderSinn for the suggestion implemented in this PR.
WeiqunZhang
force-pushed
the
grid-stride-loop
branch
from
f2af094 to
efda45f
Compare
Member
|
Can you also replace the remaining blockDim.x in that file with MT or AMREX_GPU_MAX_THREADS |
Member
Author
I have been thinking about going through all uses of |
Co-authored-by: Alexander Sinn <[email protected]>
Co-authored-by: Alexander Sinn <[email protected]>
Co-authored-by: Alexander Sinn <[email protected]>
asalmgren
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move grid-stride loop out of GPU kernels. @ashesh2512 noticed performance issues with grid-stride loops on AMD GPUs in PelePhyscis's large kernels.
Thank @AlexanderSinn for the suggestion implemented in this PR.