Skip to content

Allow C++20 HIP builds #4739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
WeiqunZhang merged 1 commit into from
Oct 29, 2025
Merged

Allow C++20 HIP builds #4739

WeiqunZhang merged 1 commit into from
Oct 29, 2025

Conversation

@BenWibking
Copy link
Contributor

@BenWibking BenWibking commented Oct 28, 2025

Summary

This removes the hard-coded C++17 compiler flag when HIP is turned on, so codes are able to use C++20 with HIP.

Additional background

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@BenWibking BenWibking changed the title allow C++20 HIP builds Allow C++20 HIP builds Oct 28, 2025
@BenWibking BenWibking requested a review from ax3l October 28, 2025 20:20
@BenWibking BenWibking mentioned this pull request Oct 28, 2025
Draft
5 tasks
@WeiqunZhang WeiqunZhang merged commit ab576e1 into AMReX-Codes:development Oct 29, 2025
71 of 73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WeiqunZhang WeiqunZhang WeiqunZhang approved these changes

@ax3l ax3l Awaiting requested review from ax3l

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BenWibking @WeiqunZhang